From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755249AbaHKWcm (ORCPT ); Mon, 11 Aug 2014 18:32:42 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:33599 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753129AbaHKWcl (ORCPT ); Mon, 11 Aug 2014 18:32:41 -0400 Date: Tue, 12 Aug 2014 06:32:06 +0800 From: Greg Kroah-Hartman To: Jeremiah Mahler Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Teodora Baluta , Andrea Merello , Joel Pelaez Jorge , Bob Copeland , Joe Perches , Arnd Bergmann , Himangi Saraogi Subject: Re: [PATCH] staging: rtl8192u/ieee80211: Fix sparse ieee80211_debug_init/_exit not declared warning Message-ID: <20140811223206.GB9475@kroah.com> References: <1407795354-1700-1-git-send-email-jmmahler@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1407795354-1700-1-git-send-email-jmmahler@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 11, 2014 at 03:15:54PM -0700, Jeremiah Mahler wrote: > A sparse warning is generated about 'ieee80211_debug_init' and > 'ieee80211_debug_exit' not being declared. > > drivers/staging/rtl8192u/ieee80211/ieee80211_module.c:275:12: warning: > symbol 'ieee80211_debug_init' was not declared. Should it be static? > drivers/staging/rtl8192u/ieee80211/ieee80211_module.c:297:13: warning: > symbol 'ieee80211_debug_exit' was not declared. Should it be static? > > These functions are used outside of this file so using static will not > work. Fix the warning by declaring the functions in the header file, > ieee80211.h > > Signed-off-by: Jeremiah Mahler > Cc: Greg Kroah-Hartman > Cc: Teodora Baluta > Cc: Andrea Merello > Cc: Joel Pelaez Jorge > Cc: Bob Copeland > Cc: Joe Perches > Cc: Arnd Bergmann > Cc: Himangi Saraogi > --- > drivers/staging/rtl8192u/ieee80211/ieee80211.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211.h b/drivers/staging/rtl8192u/ieee80211/ieee80211.h > index 1040bab..9cbda69 100644 > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211.h > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211.h > @@ -2485,6 +2485,12 @@ extern int ieee80211_wx_set_freq(struct ieee80211_device *ieee, struct iw_reques > extern int ieee80211_wx_get_freq(struct ieee80211_device *ieee, struct iw_request_info *a, > union iwreq_data *wrqu, char *b); > > +/* ieee80211_module.c */ > +#ifdef CONFIG_IEEE80211_DEBUG > +extern int __init ieee80211_debug_init(void); > +extern void __exit ieee80211_debug_exit(void); > +#endif /* CONFIG_IEEE80211_DEBUG */ > + As it's a header file, why not always have them here, no need for the ifdef. And __init and __exit don't belong in a .h function prototype. thanks, greg k-h