public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Fengguang Wu <fengguang.wu@intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
	Dave Hansen <dave.hansen@intel.com>,
	LKML <linux-kernel@vger.kernel.org>,
	lkp@01.org, Ingo Molnar <mingo@kernel.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Preeti U Murthy <preeti@linux.vnet.ibm.com>
Subject: Re: [sched] 143e1e28cb4: +17.9% aim7.jobs-per-min, -9.7% hackbench.throughput
Date: Tue, 12 Aug 2014 22:30:25 +0800	[thread overview]
Message-ID: <20140812143025.GA12963@localhost> (raw)
In-Reply-To: <20140811133352.GC9918@twins.programming.kicks-ass.net>

On Mon, Aug 11, 2014 at 03:33:52PM +0200, Peter Zijlstra wrote:
> On Sun, Aug 10, 2014 at 06:54:13PM +0800, Fengguang Wu wrote:
> > This view may be easier to read, by grouping the metrics by test case.
> > 
> > test case: brickland1/aim7/6000-page_test
> 
> OK, I have a similar system to the brickland thing (slightly different
> configuration, but should be close enough).
> 
> Now; do you have a description of each test-case someplace?

You can find our aim7 test script here:

        git clone git://git.kernel.org/pub/scm/linux/kernel/git/wfg/lkp-tests
        cd lkp-tests
        vi tests/aim7

More test scripts are available there:

        vi tests/hackbench
        vi tests/netperf
        ...

> In particular, it might be good to have a small annotation to show
> which direction is better.

The directions are listed in these files as positive/negative numbers:

        vi metric/index-*

For examples:

% head -3 metric/index-*
==> metric/index-latency.yaml <==
dbench.max_latency: -0.1
fileio.request_latency_95%_ms: -0.2
oltp.request_latency_95%_ms: -0.2

==> metric/index-perf.yaml <==
aim7.jobs-per-min: 1
dbench.throughput-MB/sec: 1
ebizzy.throughput: 1

==> metric/index-power.yaml <==
turbostat.Pkg_W: -1
turbostat.RAM_W: -1
turbostat.%c0: -0.1

==> metric/index-size.yaml <==
kernel-size.text: -1
kernel-size.data: -1
kernel-size.bss: -1

They are not the comprehensive list, but reasonably complete to list
the most important ones.

> >     128529 ± 1%     +17.9%     151594 ± 0%  TOTAL aim7.jobs-per-min
> 
> jobs per minute, + is better, so no worries there.
> 
> >     582269 ±14%     -55.6%     258617 ±16%  TOTAL softirqs.SCHED
> >     993654 ± 2%     -19.9%     795962 ± 3%  TOTAL softirqs.RCU
> >   15865125 ± 1%     -15.0%   13485882 ± 1%  TOTAL softirqs.TIMER
> 
> >   59366697 ± 3%     -46.1%   32017187 ± 7%  TOTAL cpuidle.C1-IVT.time
> >      54543 ±11%     -37.2%      34252 ±16%  TOTAL cpuidle.C1-IVT.usage
> >      19542 ± 9%     -38.3%      12057 ± 4%  TOTAL cpuidle.C1E-IVT.usage
> >   49527464 ± 6%     -32.4%   33488833 ± 4%  TOTAL cpuidle.C1E-IVT.time
> >      76064 ± 3%     -32.2%      51572 ± 6%  TOTAL cpuidle.C6-IVT.usage
> 
> Less idle time; might be good, if the work is cpubound, might be bad if
> not; hard to say.
> 
> >       2.82 ± 3%     +21.9%       3.43 ± 4%  TOTAL turbostat.%pc2
> >       4.40 ± 2%     +22.0%       5.37 ± 4%  TOTAL turbostat.%c6
> >      15.75 ± 1%      -3.4%      15.21 ± 0%  TOTAL turbostat.RAM_W
> 
> >    3150464 ± 2%     -24.2%    2387551 ± 3%  TOTAL time.voluntary_context_switches
> 
> Typically less ctxsw is better..
> 
> >        281 ± 1%     -15.1%        238 ± 0%  TOTAL time.elapsed_time
> >      29294 ± 1%     -14.3%      25093 ± 0%  TOTAL time.system_time
> 
> Less time spend (on presumably the same work) is better
> 
> >    4529818 ± 1%      -8.8%    4129398 ± 1%  TOTAL time.involuntary_context_switches
> 
> Less preemptions, also generally better
> 
> >      10655 ± 0%      +1.4%      10802 ± 0%  TOTAL time.percent_of_cpu_this_job_got
> 
> Seem an improvement; not sure.
> 
> Many more stats.. but from the above it looks like its an overall 'win';
> or am I reading the thing wrong?

I'd agree with your interpretations, too.

In case you want to make sure the exact meaning of the above values:
they are generated by scripts in stats/* and stats/hackbench would be
a good example to read.

Thanks,
Fengguang

  parent reply	other threads:[~2014-08-12 14:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-10  4:41 [sched] 143e1e28cb4: +17.9% aim7.jobs-per-min, -9.7% hackbench.throughput Fengguang Wu
2014-08-10  7:59 ` Peter Zijlstra
2014-08-10 10:54   ` Fengguang Wu
2014-08-10 15:05     ` Peter Zijlstra
2014-08-10 15:16       ` Ingo Molnar
2014-08-11  1:23       ` Fengguang Wu
2014-08-12 14:57         ` kodiak furr
2014-08-11 13:33     ` Peter Zijlstra
2014-08-12  3:59       ` Preeti U Murthy
2014-08-12  6:41         ` Peter Zijlstra
2014-08-12 14:30       ` Fengguang Wu [this message]
2014-08-25 13:47       ` Vincent Guittot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140812143025.GA12963@localhost \
    --to=fengguang.wu@intel.com \
    --cc=dave.hansen@intel.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@01.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=preeti@linux.vnet.ibm.com \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox