From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753299AbaHLP37 (ORCPT ); Tue, 12 Aug 2014 11:29:59 -0400 Received: from mail.kernel.org ([198.145.19.201]:47000 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753056AbaHLP36 (ORCPT ); Tue, 12 Aug 2014 11:29:58 -0400 Date: Tue, 12 Aug 2014 12:29:53 -0300 From: Arnaldo Carvalho de Melo To: Ingo Molnar Cc: linux-kernel@vger.kernel.org, Andi Kleen , Andi Kleen , Peter Zijlstra , Stephane Eranian , Thomas Gleixner , Jiri Olsa Subject: Re: [PATCH 05/33] perf record: Allow the user to disable time stamps Message-ID: <20140812152953.GA9820@kernel.org> References: <1407169064-25625-1-git-send-email-acme@kernel.org> <1407169064-25625-6-git-send-email-acme@kernel.org> <20140805060856.GA9453@gmail.com> <20140805133347.GH13375@kernel.org> <20140812145819.GA7737@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140812145819.GA7737@gmail.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Aug 12, 2014 at 04:58:19PM +0200, Ingo Molnar escreveu: > * Arnaldo Carvalho de Melo wrote: > > Em Tue, Aug 05, 2014 at 08:08:56AM +0200, Ingo Molnar escreveu: > > > This patch looks dangerous and misleading to me. > > I took it more from the angle: hey, it fixes a regression, i.e. > > -T/--time somehow became a noop, and also it doesn't change any > > default. > > It also states that you will get misaccounting, why that would > > happen, althought wording could've been better, as mmaps won't be > > "missing", i.e. they will be there as this governs just > > PERF_SAMPLE_TIME, not perf_event_attr.mmap, so it MMAPs may come > > after samples for its maps. > > So, I took it. > > How should we proceed? > I'd be fine with applying the patch and fixing the misleading > changelog. Done: https://git.kernel.org/cgit/linux/kernel/git/acme/linux.git/commit/?h=perf/core&id=8affc2b8c27bfc2d6e70827b746f490b62c44eaa Consider now pulling the perf-core-for-mingo tag there, I updated it after updating the changelog for this specific commit, all the rest is the same as in the previous pull req. Thanks, - Arnaldo