From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Jiri Kosina <jkosina@suse.cz>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: wacom - Fix compiler warning if !CONFIG_PM
Date: Tue, 12 Aug 2014 10:00:33 -0700 [thread overview]
Message-ID: <20140812170033.GA5563@core.coreip.homeip.net> (raw)
In-Reply-To: <20140811144238.GA10029@mail.corp.redhat.com>
On Mon, Aug 11, 2014 at 10:42:38AM -0400, Benjamin Tissoires wrote:
> On Aug 09 2014 or thereabouts, Jiri Kosina wrote:
> > On Sat, 9 Aug 2014, Geert Uytterhoeven wrote:
> >
> > > If CONFIG_PM is not set:
> > >
> > > drivers/hid/wacom_sys.c:1436: warning: ‘wacom_reset_resume’ defined but
> > > not used
> > >
> > > Protect the unused functions by #ifdef CONFIG_PM to fix this.
> > >
> > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> >
> > Thanks Geert.
> >
> > hid-wacom is in a sort of temporary mode of operation, being moved from
> > Input to HID driver.
> >
> > Adding Benjamin and Dmitry to CC, as this will likely still go through
> > Dmitry's queue.
> >
>
> Thanks for fixing this Geert.
>
> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Applied, thank you.
--
Dmitry
prev parent reply other threads:[~2014-08-12 17:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-09 17:07 [PATCH] Input: wacom - Fix compiler warning if !CONFIG_PM Geert Uytterhoeven
2014-08-09 20:39 ` Jiri Kosina
2014-08-11 14:42 ` Benjamin Tissoires
2014-08-12 17:00 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140812170033.GA5563@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=geert@linux-m68k.org \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox