From: Al Viro <viro@ZenIV.linux.org.uk>
To: David Herrmann <dh.herrmann@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Tejun Heo <tj@kernel.org>,
linux-fsdevel@vger.kernel.org, Theodore Tso <tytso@mit.edu>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH RFC 0/4] VFS revoke()
Date: Tue, 12 Aug 2014 20:14:45 +0100 [thread overview]
Message-ID: <20140812191444.GW18016@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1407869648-1449-1-git-send-email-dh.herrmann@gmail.com>
On Tue, Aug 12, 2014 at 08:54:04PM +0200, David Herrmann wrote:
> Open questions:
> * Obviously, we need to protect all calls into file->f_op->xyz(). This series
> provides enter_file() and leave_file() that can be used like:
> if (enter_file(file))
> retval = file->f_op->xyz(file, ...);
> else
> retval = -ENODEV;
> Question is, should we do this at the time we actually invoke those
> callbacks or should we do it at the syscall-entry time?
The former, obviously. The real bitch is around mmap - you don't need
that for evdev, but generic solution would better deal with that kind
of crap.
I'll post a review once I'm done with Eric's patchset; hopefully tonight or
tomorrow morning.
prev parent reply other threads:[~2014-08-12 19:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-12 18:54 [PATCH RFC 0/4] VFS revoke() David Herrmann
2014-08-12 18:54 ` [PATCH RFC 1/4] kactive: introduce generic "active"-refcounts David Herrmann
2014-08-18 21:03 ` Tejun Heo
2014-08-19 8:29 ` David Herrmann
2014-08-12 18:54 ` [PATCH RFC 2/4] vfs: add revoke() helpers David Herrmann
2014-08-19 12:27 ` Christoph Hellwig
2014-08-12 18:54 ` [PATCH RFC 3/4] Input: evdev - switch to revoke helpers David Herrmann
2014-08-12 18:54 ` [PATCH RFC 4/4] Input: evdev - drop redundant client_list David Herrmann
2014-08-12 19:14 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140812191444.GW18016@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=dh.herrmann@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox