From: Mark Brown <broonie@kernel.org>
To: Axel Lin <axel.lin@ingics.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Rob Clark <robdclark@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] regulator: Add stub for devm_regulator_get_exclusive
Date: Tue, 12 Aug 2014 22:55:15 +0100 [thread overview]
Message-ID: <20140812215515.GC17528@sirena.org.uk> (raw)
In-Reply-To: <1407807429.8958.1.camel@phoenix>
[-- Attachment #1: Type: text/plain, Size: 904 bytes --]
On Tue, Aug 12, 2014 at 09:37:09AM +0800, Axel Lin wrote:
> Fix below build error when !CONFIG_REGULATOR.
>
> CC drivers/gpu/drm/msm/hdmi/hdmi.o
> drivers/gpu/drm/msm/hdmi/hdmi.c: In function 'hdmi_init':
> drivers/gpu/drm/msm/hdmi/hdmi.c:126:3: error: implicit declaration of function 'devm_regulator_get_exclusive' [-Werror=implicit-function-declaration]
So, I just looked at that driver - it errors out on probe without the
regualtor. Are you sure the fix isn't to add a dependency on the
regulator API or convert it back to using normal regulator gets (it was
converted without comment as part of a DT conversion), or indeed to
using the bulk regulator API. It looks awfully like the driver is just
open coding devm_regulator_bulk_get() and friends.
There is no explanation at all in either the changelog or the code for
why the driver is asking for exclusive regulators.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-08-12 21:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-12 1:37 [PATCH v2] regulator: Add stub for devm_regulator_get_exclusive Axel Lin
2014-08-12 21:55 ` Mark Brown [this message]
2014-08-16 13:30 ` Axel Lin
2014-08-16 22:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140812215515.GC17528@sirena.org.uk \
--to=broonie@kernel.org \
--cc=axel.lin@ingics.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox