From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Himangi Saraogi <himangi774@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: question regarding drivers/staging/rtl8821ae/rtl8821ae/dm.c
Date: Wed, 13 Aug 2014 10:01:09 +0800 [thread overview]
Message-ID: <20140813020109.GA4973@kroah.com> (raw)
In-Reply-To: <CAB78YHyvDOEbbcbBn7pXZ-VLs43trRPY=ei47WL+QoG8OgV=1w@mail.gmail.com>
On Wed, Aug 13, 2014 at 01:06:16AM +0530, Himangi Saraogi wrote:
> Hi,
>
> In the file, I see the code:
>
> void rtl8821ae_dm_set_tx_ant_by_tx_
> info(...) {
> ...
> if ((rtlefuse->antenna_div_type == CG_TRX_HW_ANTDIV) ||
> (rtlefuse->antenna_div_type == CG_TRX_HW_ANTDIV)){
> SET_TX_DESC_TX_ANT(pdesc, pfat_table->antsel_a[mac_id]);
> }
> }
>
> Here, there is a double test. It seems the second test must be for
> CGCS_RX_HW_ANTDIV or CG_TRX_SMART_ANTDIV but am not sure. Is the second test
> just redundant or a different constant must be used?
No idea, try asking the original developers of the code (hint, almost
impossible...)
sorry,
greg k-h
parent reply other threads:[~2014-08-13 2:01 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <CAB78YHyvDOEbbcbBn7pXZ-VLs43trRPY=ei47WL+QoG8OgV=1w@mail.gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140813020109.GA4973@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=himangi774@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox