From: Ingo Molnar <mingo@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>,
Namhyung Kim <namhyung.kim@lge.com>,
LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
Andi Kleen <andi@firstfloor.org>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH] perf ui/tui: Fix a small callchain display bug
Date: Wed, 13 Aug 2014 10:19:09 +0200 [thread overview]
Message-ID: <20140813081909.GA6399@gmail.com> (raw)
In-Reply-To: <1407909761-10822-1-git-send-email-namhyung@kernel.org>
* Namhyung Kim <namhyung@kernel.org> wrote:
> The currently when perf TUI report shows callchain, the first level
> chains have bogus '+' sign even though only the last one has children.
>
> Since they are on a single line of the chain, toggling intermediate
> entries has no effect. Fix it to show '+' sign at the last entry
> only. Note that non-first level callchain entries don't have this
> problem.
>
> Before:
>
> Children Self Command Shared Object Symbols
> ---------------------------------------------------------------------------
> - 40.70% 0.00% swapper [kernel.kallsyms] [k] cpuidle_wrap_enter
> + cpuidle_wrap_enter
> + cpuidle_enter_tk
> + cpuidle_idle_call
> + cpu_idle
>
> After:
>
> Children Self Command Shared Object Symbols
> ---------------------------------------------------------------------------
> - 40.70% 0.00% swapper [kernel.kallsyms] [k] cpuidle_wrap_enter
> cpuidle_wrap_enter
> cpuidle_enter_tk
> cpuidle_idle_call
> + cpu_idle
>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Nice fix!
Acked-by: Ingo Molnar <mingo@kernel.org>
Thanks,
Ingo
next prev parent reply other threads:[~2014-08-13 8:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 6:02 [PATCH] perf ui/tui: Fix a small callchain display bug Namhyung Kim
2014-08-13 8:19 ` Ingo Molnar [this message]
2014-08-13 20:12 ` Arnaldo Carvalho de Melo
2014-08-13 20:06 ` Arnaldo Carvalho de Melo
2014-08-14 8:48 ` [tip:perf/core] perf hists browser: " tip-bot for Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140813081909.GA6399@gmail.com \
--to=mingo@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=andi@firstfloor.org \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung.kim@lge.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox