From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751810AbaHMJQN (ORCPT ); Wed, 13 Aug 2014 05:16:13 -0400 Received: from mail-pa0-f54.google.com ([209.85.220.54]:42907 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750717AbaHMJQL (ORCPT ); Wed, 13 Aug 2014 05:16:11 -0400 Date: Wed, 13 Aug 2014 14:46:05 +0530 From: Himangi Saraogi To: "David S. Miller" , Alexey Kuznetsov , James Morris , Hideaki YOSHIFUJI , Patrick McHardy , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Julia Lawall Subject: [PATCH] net/udp_offload: Drop unnecessary continue Message-ID: <20140813091605.GA2947@himangi-Dell> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Continue is not needed at the bottom of a loop. The Coccinelle semantic patch implementing this change is: @@ @@ for (...;...;...) { ... if (...) { ... - continue; } } Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- net/ipv4/udp_offload.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/net/ipv4/udp_offload.c b/net/ipv4/udp_offload.c index 59035bc..62d5b9b 100644 --- a/net/ipv4/udp_offload.c +++ b/net/ipv4/udp_offload.c @@ -269,10 +269,8 @@ unflush: continue; uh2 = (struct udphdr *)(p->data + off); - if ((*(u32 *)&uh->source != *(u32 *)&uh2->source)) { + if ((*(u32 *)&uh->source != *(u32 *)&uh2->source)) NAPI_GRO_CB(p)->same_flow = 0; - continue; - } } skb_gro_pull(skb, sizeof(struct udphdr)); /* pull encapsulating udp header */ -- 1.9.1