From: Oleg Nesterov <oleg@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Rik van Riel <riel@redhat.com>,
Mike Galbraith <umgwanakikbuti@gmail.com>,
Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
Frank Mayhar <fmayhar@google.com>,
Frederic Weisbecker <fweisbec@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Sanjay Rao <srao@redhat.com>, Larry Woodman <lwoodman@redhat.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 4/4] sched: change autogroup_move_group() to use for_each_thread()
Date: Wed, 13 Aug 2014 21:20:03 +0200 [thread overview]
Message-ID: <20140813192003.GA19334@redhat.com> (raw)
In-Reply-To: <20140813191938.GA19301@redhat.com>
Change autogroup_move_group() to use for_each_thread() instead of
buggy while_each_thread().
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---
kernel/sched/auto_group.c | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/kernel/sched/auto_group.c b/kernel/sched/auto_group.c
index e73efba..8a2e230 100644
--- a/kernel/sched/auto_group.c
+++ b/kernel/sched/auto_group.c
@@ -148,11 +148,8 @@ autogroup_move_group(struct task_struct *p, struct autogroup *ag)
if (!ACCESS_ONCE(sysctl_sched_autogroup_enabled))
goto out;
- t = p;
- do {
+ for_each_thread(p, t)
sched_move_task(t);
- } while_each_thread(p, t);
-
out:
unlock_task_sighand(p, &flags);
autogroup_kref_put(prev);
--
1.5.5.1
next prev parent reply other threads:[~2014-08-13 19:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 19:19 [PATCH 0/4] sched: don't use while_each_thread() Oleg Nesterov
2014-08-13 19:19 ` [PATCH 1/4] sched: s/do_each_thread/for_each_process_thread/ in core.c Oleg Nesterov
2014-08-20 8:18 ` [tip:sched/core] " tip-bot for Oleg Nesterov
2014-08-13 19:19 ` [PATCH 2/4] sched: s/do_each_thread/for_each_process_thread/ in debug.c Oleg Nesterov
2014-08-20 8:19 ` [tip:sched/core] " tip-bot for Oleg Nesterov
2014-08-13 19:20 ` [PATCH 3/4] sched: change thread_group_cputime() to use for_each_thread() Oleg Nesterov
2014-08-20 8:19 ` [tip:sched/core] sched: Change " tip-bot for Oleg Nesterov
2014-08-13 19:20 ` Oleg Nesterov [this message]
2014-08-20 8:19 ` [tip:sched/core] sched: Change autogroup_move_group() " tip-bot for Oleg Nesterov
2014-08-13 19:23 ` [PATCH 0/4] sched: don't use while_each_thread() Peter Zijlstra
2014-08-17 15:25 ` [PATCH 0/2] sched: tasklist_lock cleanups (Was: don't use while_each_thread()) Oleg Nesterov
2014-08-17 15:26 ` [PATCH 1/2] sched: normalize_rt_tasks: don't use _irqsave for tasklist_lock, use task_rq_lock() Oleg Nesterov
2014-08-17 15:26 ` [PATCH 2/2] sched: print_rq: don't use tasklist_lock Oleg Nesterov
2014-08-17 21:14 ` [PATCH 0/2] sched: tasklist_lock cleanups (Was: don't use while_each_thread()) Kirill Tkhai
2014-08-18 15:09 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140813192003.GA19334@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=fmayhar@google.com \
--cc=fweisbec@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lwoodman@redhat.com \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=seto.hidetoshi@jp.fujitsu.com \
--cc=srao@redhat.com \
--cc=umgwanakikbuti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox