From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
Namhyung Kim <namhyung.kim@lge.com>,
LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
David Ahern <dsahern@gmail.com>, Minchan Kim <minchan@kernel.org>
Subject: Re: [PATCH 01/13] perf script: Fix possible memory leaks
Date: Wed, 13 Aug 2014 16:27:54 -0300 [thread overview]
Message-ID: <20140813192754.GF2718@kernel.org> (raw)
In-Reply-To: <87y4usdg3v.fsf@sejong.aot.lge.com>
Em Wed, Aug 13, 2014 at 04:05:24PM +0900, Namhyung Kim escreveu:
> On Wed, 13 Aug 2014 09:21:31 +0300, Adrian Hunter wrote:
> > On 08/12/2014 09:40 AM, Namhyung Kim wrote:
> >> input = open(file.path, O_RDONLY); /* input_name */
> >> if (input < 0) {
> >> perror("failed to open file");
> >> - return -1;
> >> + err = -errno;
> >
> > Need to get errno before calling perror().
>
> Argh, right.
I'll fix this up, no need to resubmit.
- Arnaldo
next prev parent reply other threads:[~2014-08-13 19:28 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-12 6:40 [PATCHSET 00/13] perf tools: Fix vmlinux search path initialization Namhyung Kim
2014-08-12 6:40 ` [PATCH 01/13] perf script: Fix possible memory leaks Namhyung Kim
2014-08-13 6:21 ` Adrian Hunter
2014-08-13 7:05 ` Namhyung Kim
2014-08-13 19:27 ` Arnaldo Carvalho de Melo [this message]
2014-08-14 8:45 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-08-12 6:40 ` [PATCH 02/13] perf tools: Fix a memory leak in vmlinux_path__init() Namhyung Kim
2014-08-14 8:45 ` [tip:perf/core] perf symbols: " tip-bot for Namhyung Kim
2014-08-12 6:40 ` [PATCH 03/13] perf annotate: Move session handling out of __cmd_annotate() Namhyung Kim
2014-08-13 11:48 ` Jiri Olsa
2014-08-19 6:03 ` Namhyung Kim
2014-08-14 8:46 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-08-12 6:40 ` [PATCH 04/13] perf buildid-cache: Move session handling into cmd_buildid_cache() Namhyung Kim
2014-08-14 8:46 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-08-12 6:40 ` [PATCH 05/13] perf inject: Move session handling out of __cmd_inject() Namhyung Kim
2014-08-14 8:46 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-08-12 6:40 ` [PATCH 06/13] perf kmem: Move session handling out of __cmd_kmem() Namhyung Kim
2014-08-14 8:46 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-08-12 6:40 ` [PATCH 07/13] perf kvm: Move call to symbol__init() after creating session Namhyung Kim
2014-08-14 8:47 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-08-12 6:40 ` [PATCH 08/13] perf lock: " Namhyung Kim
2014-08-14 8:47 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-08-12 6:40 ` [PATCH 09/13] perf sched: " Namhyung Kim
2014-08-14 8:47 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-08-12 6:40 ` [PATCH 10/13] perf script: " Namhyung Kim
2014-08-14 8:47 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-08-12 6:40 ` [PATCH 11/13] perf timechart: " Namhyung Kim
2014-08-14 8:48 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-08-12 6:40 ` [PATCH 12/13] perf trace: " Namhyung Kim
2014-08-14 8:48 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-08-12 6:40 ` [PATCH 13/13] perf tools: Check recorded kernel version when finding vmlinux Namhyung Kim
2014-08-14 8:48 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-08-13 12:49 ` [PATCHSET 00/13] perf tools: Fix vmlinux search path initialization Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140813192754.GF2718@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=adrian.hunter@intel.com \
--cc=dsahern@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).