From: Peter Zijlstra <peterz@infradead.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-kernel@vger.kernel.org, mingo@kernel.org,
eranian@google.com, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 4/5] perf, x86: Add INST_RETIRED.ALL workarounds
Date: Thu, 14 Aug 2014 09:10:26 +0200 [thread overview]
Message-ID: <20140814071026.GE16043@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1407979069-7121-5-git-send-email-andi@firstfloor.org>
[-- Attachment #1: Type: text/plain, Size: 524 bytes --]
On Wed, Aug 13, 2014 at 06:17:48PM -0700, Andi Kleen wrote:
> v2: Use correct event name in description. Use EVENT() macro.
> +static unsigned bdw_limit_period(struct perf_event *event, unsigned left)
> +{
> + if ((event->hw.config & 0xffff) ==
I was thinking you should use INTEL_ARCH_EVENT_MASK or something instead
of the raw 0xFFFF there, but that X86_CONFIG() usage is nice too :-)
> + X86_CONFIG(.event=0xc0, .umask=0x01)) {
> + if (left < 128)
> + left = 128;
> + left &= ~0x3fu;
> + }
> + return left;
> +}
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-08-14 7:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-14 1:17 Updated Broadwell perf patchkit Andi Kleen
2014-08-14 1:17 ` [PATCH 1/5] perf, x86: Remove incorrect model number from Haswell perf Andi Kleen
2014-08-14 1:17 ` [PATCH 2/5] perf, x86: Document all Haswell models Andi Kleen
2014-08-14 7:01 ` Peter Zijlstra
2014-08-14 15:00 ` Andi Kleen
2014-08-14 1:17 ` [PATCH 3/5] perf, x86: Add Broadwell core support Andi Kleen
2014-08-14 7:07 ` Peter Zijlstra
2014-08-14 7:32 ` Peter Zijlstra
2014-08-14 14:58 ` Andi Kleen
2014-08-14 15:10 ` Peter Zijlstra
2014-08-14 1:17 ` [PATCH 4/5] perf, x86: Add INST_RETIRED.ALL workarounds Andi Kleen
2014-08-14 4:46 ` Stephane Eranian
2014-08-14 14:30 ` Andi Kleen
2014-08-14 17:47 ` Stephane Eranian
2014-08-14 18:41 ` Andi Kleen
2014-08-15 14:31 ` Peter Zijlstra
2014-08-15 17:21 ` Andi Kleen
2014-08-14 7:10 ` Peter Zijlstra [this message]
2014-08-14 1:17 ` [PATCH 5/5] perf, x86: Use Broadwell cache event list for Haswell Andi Kleen
-- strict thread matches above, loose matches on Subject: below --
2014-08-25 22:43 Broadwell perf support Andi Kleen
2014-08-25 22:43 ` [PATCH 4/5] perf, x86: Add INST_RETIRED.ALL workarounds Andi Kleen
2014-09-01 13:41 ` Peter Zijlstra
2014-08-27 21:03 perf, x86: Updated Broadwell patchkit Andi Kleen
2014-08-27 21:03 ` [PATCH 4/5] perf, x86: Add INST_RETIRED.ALL workarounds Andi Kleen
2014-09-02 18:44 [PATCH 1/5] perf, x86: Remove incorrect model number from Haswell perf Andi Kleen
2014-09-02 18:44 ` [PATCH 4/5] perf, x86: Add INST_RETIRED.ALL workarounds Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140814071026.GE16043@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox