From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754053AbaHNHQ2 (ORCPT ); Thu, 14 Aug 2014 03:16:28 -0400 Received: from e06smtp14.uk.ibm.com ([195.75.94.110]:52633 "EHLO e06smtp14.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752726AbaHNHQ0 (ORCPT ); Thu, 14 Aug 2014 03:16:26 -0400 Date: Thu, 14 Aug 2014 09:16:14 +0200 From: Martin Schwidefsky To: Minchan Kim Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michael Kerrisk , Linux API , Hugh Dickins , Johannes Weiner , Rik van Riel , KOSAKI Motohiro , Mel Gorman , Jason Evans , Zhang Yanfei , "Kirill A. Shutemov" , Heiko Carstens , Dominik Dingel , Christian Borntraeger , linux-s390@vger.kernel.org, Gerald Schaefer Subject: Re: [PATCH v14 5/8] s390: add pmd_[dirty|mkclean] for THP Message-ID: <20140814091614.4a0d5178@mschwide> In-Reply-To: <1407981212-17818-6-git-send-email-minchan@kernel.org> References: <1407981212-17818-1-git-send-email-minchan@kernel.org> <1407981212-17818-6-git-send-email-minchan@kernel.org> X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.13; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14081407-1948-0000-0000-000000CFC15F Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 14 Aug 2014 10:53:29 +0900 Minchan Kim wrote: > MADV_FREE needs pmd_dirty and pmd_mkclean for detecting recent > overwrite of the contents since MADV_FREE syscall is called for > THP page but for s390 pmds only referenced bit is available > because there is no free bit left in the pmd entry for the > software dirty bit so this patch adds dumb pmd_dirty which > returns always true by suggesting by Martin. > > They finally find a solution in future. > http://marc.info/?l=linux-api&m=140440328820808&w=2 The solution is already there, see git commit 152125b7a882df36. You can drop this patch. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.