Re: [PATCH RFC] time,signal: protect resource use statistics with seqlock

Mike Galbraith
2014-08-15T05:19:38Z

On Thu, 2014-08-14 at 19:48 +0200, Oleg Nesterov wrote:
> On 08/14, Oleg Nesterov wrote:
> >
> > OK, lets forget about alternative approach for now. We can reconsider
> > it later. At least I have to admit that seqlock is more straighforward.
>
> Yes.
>
> But just for record, the "lockless" version doesn't look that bad to me,
>
> void thread_group_cputime(struct task_struct *tsk, struct task_cputime *times)
> {
> struct signal_struct *sig = tsk->signal;
> bool lockless, is_dead;
> struct task_struct *t;
> unsigned long flags;
> u64 exec;
>
> lockless = true;
> is_dead = !lock_task_sighand(p, &flags);
> retry:
> times->utime = sig->utime;
> times->stime = sig->stime;
> times->sum_exec_runtime = exec = sig->sum_sched_runtime;
> if (is_dead)
> return;
>
> if (lockless)
> unlock_task_sighand(p, &flags);
>
> rcu_read_lock();
> for_each_thread(tsk, t) {
> cputime_t utime, stime;
> task_cputime(t, &utime, &stime);
> times->utime += utime;
> times->stime += stime;
> times->sum_exec_runtime += task_sched_runtime(t);
> }
> rcu_read_unlock();
>
> if (lockless) {
> lockless = false;
> is_dead = !lock_task_sighand(p, &flags);
> if (is_dead || exec != sig->sum_sched_runtime)
> goto retry;
> }
> unlock_task_sighand(p, &flags);
> }
>
> The obvious problem is that we should shift lock_task_sighand() from the
> callers to thread_group_cputime() first, or add thread_group_cputime_lockless()
> and change the current users one by one.
>
> And of course, stats_lock is more generic.

Yours looks nice to me, particularly in that it doesn't munge structure
layout, could perhaps be backported to fix up production kernels.

For the N threads doing this on N cores case, seems rq->lock hammering
will still be a source of major box wide pain. Is there any correctness
reason to add up unaccounted ->on_cpu beans, or is that just value
added? Seems to me it can't matter, as you traverse, what you added up
on previous threads becomes ever more stale as you proceed, so big boxen
would be better off not doing that.

-Mike