From: Andi Kleen <ak@linux.intel.com>
To: Stephane Eranian <eranian@google.com>
Cc: Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@redhat.com>,
Arnaldo Carvalho de Melo <acme@infradead.org>,
Andi Kleen <andi@firstfloor.org>,
Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH 4/5] perf, x86: Add INST_RETIRED.ALL workarounds
Date: Thu, 14 Aug 2014 11:41:15 -0700 [thread overview]
Message-ID: <20140814184115.GS5803@tassilo.jf.intel.com> (raw)
In-Reply-To: <CABPqkBQVwGH7GAVXAXjR1inWnWYeWuVG7Aj-aWAzAksdGq8oeg@mail.gmail.com>
On Thu, Aug 14, 2014 at 07:47:56PM +0200, Stephane Eranian wrote:
> [+perf tool maintainers]
>
> On Thu, Aug 14, 2014 at 4:30 PM, Andi Kleen <ak@linux.intel.com> wrote:
> >
> > I understand all your points, but there's no alternative.
> > The only other way would be to disable INST_RETIRED.ALL.
> >
> You cannot do that either. INST_RETIRED:ALL is important.
> I assume the bug applies whether or not the event is used
> with a filter.
>
> I think we need to ensure that by looking at the perf.data file,
> one can reconstruct the total number of inst_Retired:all
> occurrences for the run. With a fixed period, one would do
> num_samples * fixed_period. I know the Gooda tool does
> that. It is used to estimate the number of events captured
> vs. the number of events occurring.
Is that really a problem?
Normally periods are not that small, especially not for
instruction retired. I don't think you can run such
a small period on instruction retired for
any significant time without throttling.
With sensible periods, let's say >10k, the error from
losing a few bits is very small. It would surprise
me if you can actually measure it.
There will be always much more jitter just from standard
system noise.
-Andi
next prev parent reply other threads:[~2014-08-14 18:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-14 1:17 Updated Broadwell perf patchkit Andi Kleen
2014-08-14 1:17 ` [PATCH 1/5] perf, x86: Remove incorrect model number from Haswell perf Andi Kleen
2014-08-14 1:17 ` [PATCH 2/5] perf, x86: Document all Haswell models Andi Kleen
2014-08-14 7:01 ` Peter Zijlstra
2014-08-14 15:00 ` Andi Kleen
2014-08-14 1:17 ` [PATCH 3/5] perf, x86: Add Broadwell core support Andi Kleen
2014-08-14 7:07 ` Peter Zijlstra
2014-08-14 7:32 ` Peter Zijlstra
2014-08-14 14:58 ` Andi Kleen
2014-08-14 15:10 ` Peter Zijlstra
2014-08-14 1:17 ` [PATCH 4/5] perf, x86: Add INST_RETIRED.ALL workarounds Andi Kleen
2014-08-14 4:46 ` Stephane Eranian
2014-08-14 14:30 ` Andi Kleen
2014-08-14 17:47 ` Stephane Eranian
2014-08-14 18:41 ` Andi Kleen [this message]
2014-08-15 14:31 ` Peter Zijlstra
2014-08-15 17:21 ` Andi Kleen
2014-08-14 7:10 ` Peter Zijlstra
2014-08-14 1:17 ` [PATCH 5/5] perf, x86: Use Broadwell cache event list for Haswell Andi Kleen
-- strict thread matches above, loose matches on Subject: below --
2014-08-25 22:43 Broadwell perf support Andi Kleen
2014-08-25 22:43 ` [PATCH 4/5] perf, x86: Add INST_RETIRED.ALL workarounds Andi Kleen
2014-09-01 13:41 ` Peter Zijlstra
2014-08-27 21:03 perf, x86: Updated Broadwell patchkit Andi Kleen
2014-08-27 21:03 ` [PATCH 4/5] perf, x86: Add INST_RETIRED.ALL workarounds Andi Kleen
2014-09-02 18:44 [PATCH 1/5] perf, x86: Remove incorrect model number from Haswell perf Andi Kleen
2014-09-02 18:44 ` [PATCH 4/5] perf, x86: Add INST_RETIRED.ALL workarounds Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140814184115.GS5803@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=acme@infradead.org \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox