Re: [PATCH] drivers: staging: vt6655: wpactl.c checkpatch clean-up

Greg KH
2014-08-15T15:27:40Z

On Mon, Aug 11, 2014 at 11:32:58AM +0530, Avinash kumar wrote:
> Cleaned all C99 comments related warnings
>
> Signed-off-by: Avinash kumar <avi.kp.137@gmail.com>
>
> ---
> drivers/staging/vt6655/wpactl.c | 40 +++++++++++++++++++--------------------
> 1 file changed, 20 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/staging/vt6655/wpactl.c b/drivers/staging/vt6655/wpactl.c
> index 8392d4d..96d2562 100644
> --- a/drivers/staging/vt6655/wpactl.c
> +++ b/drivers/staging/vt6655/wpactl.c
> @@ -299,7 +299,7 @@ int wpa_set_keys(PSDevice pDevice, void *ctx,
> else
> byKeyDecMode = KEY_CTL_WEP;
>
> - // Fix HCT test that set 256 bits KEY and Ndis802_11Encryption3Enabled
> + /* Fix HCT test that set 256 bits KEY and Ndis802_11Encryption3Enabled*/

Why not a ' ' at the end of this line, before the '*/' part? Yes, it
pushes you over the 80 character limit, but that's ok, it's something to
fix up later.

> if (pDevice->eEncryptionStatus == Ndis802_11Encryption3Enabled) {
> if (param->u.wpa_key.key_len == MAX_KEY_LEN)
> byKeyDecMode = KEY_CTL_TKIP;
> @@ -314,23 +314,23 @@ int wpa_set_keys(PSDevice pDevice, void *ctx,
> byKeyDecMode = KEY_CTL_WEP;
> }
>
> - // Check TKIP key length
> + /* Check TKIP key length*/

Ok, no excuse this time :)

Please fix this all up and resend.

thanks,

greg k-h