From: Benjamin LaHaise <bcrl@kvack.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-aio@kvack.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 7/7] aio: use iovec array rather than the single one
Date: Fri, 15 Aug 2014 21:46:34 -0400 [thread overview]
Message-ID: <20140816014634.GA27088@kvack.org> (raw)
In-Reply-To: <CA+55aFyYt41jie6N1UyawPYYnpRAMKcRG8wRTa_ShPreT24qTw@mail.gmail.com>
On Fri, Aug 15, 2014 at 06:35:25PM -0600, Linus Torvalds wrote:
> Ben,
>
> *please* stop doing this kind of crap.
>
> You're creating fake emails with invalid senders. That's simply not acceptable.
...
I'll admit this was my mistake and I should have caught it while reviewing
the emails. At least in the past my mail client has generated the correct
From: headers, but I made a mistake somewhere in the process today. Evidently
passing in the --from= parameter to git-format-patch has been missing from
my scripts forever.
That said: git should *not* default to generating fake From: headers in
generated emails! Having the git default being completely unreasonable in
this case makes absolutely no sense to me, especially when git already
knows what my bloody email address is! It's wrong, it's clear that it's
wrong, so why is the default that way?
Damned rope shooting my foot off. Please excuse me while I go find a medic
to stop the bleeding...
-ben
--
"Thought is the essence of where you are now."
prev parent reply other threads:[~2014-08-16 1:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-15 17:23 [PATCH 0/7] aio: changes for 3.17 Benjamin LaHaise
2014-08-15 17:24 ` [PATCH 1/7] aio: change exit_aio() to load mm->ioctx_table once and avoid rcu_read_lock() Oleg Nesterov
2014-08-15 17:24 ` [PATCH 2/7] aio: kill the misleading rcu read locks in ioctx_add_table() and kill_ioctx() Oleg Nesterov
2014-08-15 17:24 ` [PATCH 3/7] aio: remove no longer needed preempt_disable() Benjamin LaHaise
2014-08-15 17:24 ` [PATCH 4/7] aio: remove the needless registration of ring file's private_data Gu Zheng
2014-08-15 17:25 ` [PATCH 5/7] aio: use the macro rather than the inline magic number Gu Zheng
2014-08-15 17:25 ` [PATCH 6/7] aio: fix some comments Gu Zheng
2014-08-15 17:25 ` [PATCH 7/7] aio: use iovec array rather than the single one Gu Zheng
2014-08-16 0:35 ` Linus Torvalds
2014-08-16 1:46 ` Benjamin LaHaise [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140816014634.GA27088@kvack.org \
--to=bcrl@kvack.org \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox