* [PATCH] rtl8188eu: Replace rcu_dereference() with rcu_access_pointer()
@ 2014-08-17 11:43 Andreea-Cristina Bernat
2014-08-30 20:42 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Andreea-Cristina Bernat @ 2014-08-17 11:43 UTC (permalink / raw)
To: gregkh, Larry.Finger, oat.elena, devel, linux-kernel; +Cc: paulmck
The "rcu_dereference()" call is used directly in a condition.
Since its return value is never dereferenced it is recommended to use
"rcu_access_pointer()" instead of "rcu_dereference()".
Therefore, this patch makes the replacement.
The following Coccinelle semantic patch was used:
@@
@@
(
if(
(<+...
- rcu_dereference
+ rcu_access_pointer
(...)
...+>)) {...}
|
while(
(<+...
- rcu_dereference
+ rcu_access_pointer
(...)
...+>)) {...}
)
Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com>
---
drivers/staging/rtl8188eu/core/rtw_mlme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c b/drivers/staging/rtl8188eu/core/rtw_mlme.c
index 155282e..8643003 100644
--- a/drivers/staging/rtl8188eu/core/rtw_mlme.c
+++ b/drivers/staging/rtl8188eu/core/rtw_mlme.c
@@ -1544,7 +1544,7 @@ void rtw_dynamic_check_timer_handlder(struct adapter *adapter)
rcu_read_lock();
- if (rcu_dereference(adapter->pnetdev->rx_handler_data) &&
+ if (rcu_access_pointer(adapter->pnetdev->rx_handler_data) &&
(check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) == true)) {
/* expire NAT2.5 entry */
nat25_db_expire(adapter);
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] rtl8188eu: Replace rcu_dereference() with rcu_access_pointer()
2014-08-17 11:43 [PATCH] rtl8188eu: Replace rcu_dereference() with rcu_access_pointer() Andreea-Cristina Bernat
@ 2014-08-30 20:42 ` Greg KH
2014-09-04 20:58 ` Andreea Bernat
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2014-08-30 20:42 UTC (permalink / raw)
To: Andreea-Cristina Bernat
Cc: Larry.Finger, oat.elena, devel, linux-kernel, paulmck
On Sun, Aug 17, 2014 at 02:43:37PM +0300, Andreea-Cristina Bernat wrote:
> The "rcu_dereference()" call is used directly in a condition.
> Since its return value is never dereferenced it is recommended to use
> "rcu_access_pointer()" instead of "rcu_dereference()".
> Therefore, this patch makes the replacement.
>
> The following Coccinelle semantic patch was used:
> @@
> @@
>
> (
> if(
> (<+...
> - rcu_dereference
> + rcu_access_pointer
> (...)
> ...+>)) {...}
> |
> while(
> (<+...
> - rcu_dereference
> + rcu_access_pointer
> (...)
> ...+>)) {...}
> )
>
> Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com>
> ---
> drivers/staging/rtl8188eu/core/rtw_mlme.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This patch fails to apply to my tree, can you refresh it against the
staging-next branch of the staging.git tree on kernel.org and resend?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] rtl8188eu: Replace rcu_dereference() with rcu_access_pointer()
2014-08-30 20:42 ` Greg KH
@ 2014-09-04 20:58 ` Andreea Bernat
2014-09-04 21:23 ` Larry Finger
2014-09-04 21:38 ` Greg KH
0 siblings, 2 replies; 6+ messages in thread
From: Andreea Bernat @ 2014-09-04 20:58 UTC (permalink / raw)
To: Greg KH; +Cc: Larry.Finger, Elena Oat, devel, linux-kernel, Paul McKenney
Hello,
I cloned this:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
and after moved to staging-next branch, but in both cases, in
those files I don't find any use of rcu_dereference() call (the call
which I am looking for to modify).
Thank you,
Andreea
2014-08-30 23:42 GMT+03:00 Greg KH <gregkh@linuxfoundation.org>:
> On Sun, Aug 17, 2014 at 02:43:37PM +0300, Andreea-Cristina Bernat wrote:
>> The "rcu_dereference()" call is used directly in a condition.
>> Since its return value is never dereferenced it is recommended to use
>> "rcu_access_pointer()" instead of "rcu_dereference()".
>> Therefore, this patch makes the replacement.
>>
>> The following Coccinelle semantic patch was used:
>> @@
>> @@
>>
>> (
>> if(
>> (<+...
>> - rcu_dereference
>> + rcu_access_pointer
>> (...)
>> ...+>)) {...}
>> |
>> while(
>> (<+...
>> - rcu_dereference
>> + rcu_access_pointer
>> (...)
>> ...+>)) {...}
>> )
>>
>> Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com>
>> ---
>> drivers/staging/rtl8188eu/core/rtw_mlme.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> This patch fails to apply to my tree, can you refresh it against the
> staging-next branch of the staging.git tree on kernel.org and resend?
>
> thanks,
>
> greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] rtl8188eu: Replace rcu_dereference() with rcu_access_pointer()
2014-09-04 20:58 ` Andreea Bernat
@ 2014-09-04 21:23 ` Larry Finger
2014-09-04 21:38 ` Greg KH
1 sibling, 0 replies; 6+ messages in thread
From: Larry Finger @ 2014-09-04 21:23 UTC (permalink / raw)
To: Andreea Bernat, Greg KH; +Cc: Elena Oat, devel, linux-kernel, Paul McKenney
On 09/04/2014 03:58 PM, Andreea Bernat wrote:
> Hello,
>
> I cloned this:
> git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
>
> and after moved to staging-next branch, but in both cases, in
> those files I don't find any use of rcu_dereference() call (the call
> which I am looking for to modify).
The rcu_dereference() call in core/rtw_mlme.c is no longer there in mainline
3.17, thus it was removed some time ago.
There is a similar reference in os_dep/recv_linux.c. Perhaps it should be removed.
This problem shows the importance of working with the latest pull of the staging
repo when working with staging code. Even then patches may suffer mid-air
collisions if multiple devs are working on a particular piece of code.
Larry
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] rtl8188eu: Replace rcu_dereference() with rcu_access_pointer()
2014-09-04 20:58 ` Andreea Bernat
2014-09-04 21:23 ` Larry Finger
@ 2014-09-04 21:38 ` Greg KH
2014-09-05 18:21 ` Andreea Bernat
1 sibling, 1 reply; 6+ messages in thread
From: Greg KH @ 2014-09-04 21:38 UTC (permalink / raw)
To: Andreea Bernat
Cc: Larry.Finger, Elena Oat, devel, linux-kernel, Paul McKenney
On Thu, Sep 04, 2014 at 11:58:36PM +0300, Andreea Bernat wrote:
> Hello,
>
> I cloned this:
> git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
>
> and after moved to staging-next branch, but in both cases, in
> those files I don't find any use of rcu_dereference() call (the call
> which I am looking for to modify).
Then there's nothing left to be done here, right? :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] rtl8188eu: Replace rcu_dereference() with rcu_access_pointer()
2014-09-04 21:38 ` Greg KH
@ 2014-09-05 18:21 ` Andreea Bernat
0 siblings, 0 replies; 6+ messages in thread
From: Andreea Bernat @ 2014-09-05 18:21 UTC (permalink / raw)
To: Greg KH; +Cc: Larry.Finger, Elena Oat, devel, linux-kernel, Paul McKenney
2014-09-05 0:38 GMT+03:00 Greg KH <gregkh@linuxfoundation.org>:
> On Thu, Sep 04, 2014 at 11:58:36PM +0300, Andreea Bernat wrote:
>> Hello,
>>
>> I cloned this:
>> git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
>>
>> and after moved to staging-next branch, but in both cases, in
>> those files I don't find any use of rcu_dereference() call (the call
>> which I am looking for to modify).
>
> Then there's nothing left to be done here, right? :)
Yes :-)
Thank you,
Andreea
>
> thanks,
>
> greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-09-05 18:21 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-17 11:43 [PATCH] rtl8188eu: Replace rcu_dereference() with rcu_access_pointer() Andreea-Cristina Bernat
2014-08-30 20:42 ` Greg KH
2014-09-04 20:58 ` Andreea Bernat
2014-09-04 21:23 ` Larry Finger
2014-09-04 21:38 ` Greg KH
2014-09-05 18:21 ` Andreea Bernat
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox