* [PATCH] os_dep: Replace rcu_dereference() with rcu_access_pointer()
@ 2014-08-17 13:39 Andreea-Cristina Bernat
2014-08-30 21:04 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Andreea-Cristina Bernat @ 2014-08-17 13:39 UTC (permalink / raw)
To: gregkh, Larry.Finger, navin.patidar, davem, jasowang, stsp,
dborkman, Jes.Sorensen, devel, linux-kernel
Cc: paulmck
The "rcu_dereference()" call is used directly in a condition.
Since its return value is never dereferenced it is recommended to use
"rcu_access_pointer()" instead of "rcu_dereference()".
Therefore, this patch makes the replacement.
The following Coccinelle semantic patch was used:
@@
@@
(
if(
(<+...
- rcu_dereference
+ rcu_access_pointer
(...)
...+>)) {...}
|
while(
(<+...
- rcu_dereference
+ rcu_access_pointer
(...)
...+>)) {...}
)
Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com>
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/os_intfs.c b/drivers/staging/rtl8188eu/os_dep/os_intfs.c
index 0e0c32d..4bb76e5 100644
--- a/drivers/staging/rtl8188eu/os_dep/os_intfs.c
+++ b/drivers/staging/rtl8188eu/os_dep/os_intfs.c
@@ -1010,7 +1010,7 @@ void netdev_br_init(struct net_device *netdev)
rcu_read_lock();
- if (rcu_dereference(adapter->pnetdev->rx_handler_data)) {
+ if (rcu_access_pointer(adapter->pnetdev->rx_handler_data)) {
struct net_device *br_netdev;
struct net *devnet = NULL;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] os_dep: Replace rcu_dereference() with rcu_access_pointer()
2014-08-17 13:39 [PATCH] os_dep: Replace rcu_dereference() with rcu_access_pointer() Andreea-Cristina Bernat
@ 2014-08-30 21:04 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2014-08-30 21:04 UTC (permalink / raw)
To: Andreea-Cristina Bernat
Cc: Larry.Finger, navin.patidar, davem, jasowang, stsp, dborkman,
Jes.Sorensen, devel, linux-kernel, paulmck
On Sun, Aug 17, 2014 at 04:39:16PM +0300, Andreea-Cristina Bernat wrote:
> The "rcu_dereference()" call is used directly in a condition.
> Since its return value is never dereferenced it is recommended to use
> "rcu_access_pointer()" instead of "rcu_dereference()".
> Therefore, this patch makes the replacement.
>
> The following Coccinelle semantic patch was used:
> @@
> @@
>
> (
> if(
> (<+...
> - rcu_dereference
> + rcu_access_pointer
> (...)
> ...+>)) {...}
> |
> while(
> (<+...
> - rcu_dereference
> + rcu_access_pointer
> (...)
> ...+>)) {...}
> )
>
> Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com>
> ---
> drivers/staging/rtl8188eu/os_dep/os_intfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This also doesn't apply :(
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-08-30 21:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-17 13:39 [PATCH] os_dep: Replace rcu_dereference() with rcu_access_pointer() Andreea-Cristina Bernat
2014-08-30 21:04 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox