From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Joe Perches <joe@perches.com>
Cc: Forest Bond <forest@alittletooquiet.net>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: vt6655: Convert DBG_PRT to pr_<level>
Date: Sun, 17 Aug 2014 07:18:20 -0700 [thread overview]
Message-ID: <20140817141820.GA14213@kroah.com> (raw)
In-Reply-To: <74a25bc8e53f22901ce926c47d3d8eac37fe1c91.1407740390.git.joe@perches.com>
On Mon, Aug 11, 2014 at 12:03:18AM -0700, Joe Perches wrote:
> DBG_PRT uses are unnecessarily complex.
>
> Convert DBG_PRT msglevel to pr_<level>.
> This changes the KERN_<level> type of several uses.
> It also enables dynamic_debug for the pr_debug conversions.
>
> This patch can be a prelude to converting these pr_<level>
> uses to dev_<level> as appropriate.
>
> Other changes:
>
> Realign arguments of these conversions.
> Remove now unused static int msglevel declarations.
> Remove now unused DBG_PRT #define.
>
> Compile tested only.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Due to patches for this driver sent before this one, that are now in my
staging-next branch of my staging.git tree, this patch doesn't apply :(
Can you refresh it and resend?
thanks,
greg k-h
next prev parent reply other threads:[~2014-08-17 14:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-11 7:03 [PATCH] staging: vt6655: Convert DBG_PRT to pr_<level> Joe Perches
2014-08-17 14:18 ` Greg Kroah-Hartman [this message]
2014-08-17 16:17 ` [PATCH V2] " Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140817141820.GA14213@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox