From: Mark Brown <broonie@kernel.org>
To: Tim Kryger <tim.kryger@gmail.com>
Cc: Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
Ulf Hansson <ulf.hansson@linaro.org>,
Chris Ball <chris@printf.net>,
Seungwon Jeon <tgih.jun@samsung.com>,
Haijun Zhang <Haijun.Zhang@freescale.com>,
Doug Anderson <dianders@chromium.org>,
Olof Johansson <olof@lixom.net>,
Yuvaraj Kumar C D <yuvaraj.cd@gmail.com>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
linux-mmc <linux-mmc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] mmc: core: Use regulator_get_voltage() if OCR mask is empty.
Date: Mon, 18 Aug 2014 08:18:32 -0500 [thread overview]
Message-ID: <20140818131832.GS14537@sirena.org.uk> (raw)
In-Reply-To: <CAD7vxxKTk2Na9B4ae6EGT8HaKDRp0iu4zX1tB8DPtmePKbHrLw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 739 bytes --]
On Sun, Aug 17, 2014 at 10:11:30AM -0700, Tim Kryger wrote:
> On Fri, Aug 15, 2014 at 3:29 PM, Mark Brown <broonie@kernel.org> wrote:
> > Nobody has written suitable code, and please bear in mind that even if
> > the code is written there will probably be cases where it's too
> > expensive for whatever reason so Javier's change is going to be needed.
> I fail to see how replicating similar logic at all current
> regulator_list_voltage call sites would be any more efficient than
> handling this directly in regulator core.
If you feel like writing a helper function that would be fine but
list_voltage() can't be doing expensive talking to the hardware
operations - it needs to be something people can be comfortable calling
a lot.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-08-18 14:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-14 12:39 [PATCH 1/1] mmc: core: Use regulator_get_voltage() if OCR mask is empty Javier Martinez Canillas
2014-08-14 14:13 ` Tim Kryger
2014-08-14 15:19 ` Mark Brown
2014-08-15 5:36 ` Tim Kryger
2014-08-15 7:48 ` Javier Martinez Canillas
2014-08-15 9:55 ` Mark Brown
2014-08-15 11:13 ` Javier Martinez Canillas
2014-08-15 14:51 ` Ulf Hansson
2014-08-16 12:59 ` Mark Brown
2014-08-19 11:29 ` Javier Martinez Canillas
2014-08-19 12:43 ` Ulf Hansson
2014-08-19 12:54 ` Javier Martinez Canillas
2014-08-15 14:19 ` Tim Kryger
2014-08-15 22:29 ` Mark Brown
2014-08-17 17:11 ` Tim Kryger
2014-08-18 13:18 ` Mark Brown [this message]
2014-08-15 8:59 ` Mark Brown
2014-08-14 15:29 ` Javier Martinez Canillas
2014-08-19 12:51 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140818131832.GS14537@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Haijun.Zhang@freescale.com \
--cc=chris@printf.net \
--cc=dianders@chromium.org \
--cc=javier.martinez@collabora.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=tgih.jun@samsung.com \
--cc=tim.kryger@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=yuvaraj.cd@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox