From: Don Zickus <dzickus@redhat.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: akpm@linux-foundation.org, kvm@vger.kernel.org,
pbonzini@redhat.com, mingo@redhat.com,
LKML <linux-kernel@vger.kernel.org>,
Ulrich Obergfell <uobergfe@redhat.com>,
Andrew Jones <drjones@redhat.com>
Subject: Re: [PATCH 4/5] watchdog: control hard lockup detection default
Date: Mon, 18 Aug 2014 11:07:52 -0400 [thread overview]
Message-ID: <20140818150752.GS49576@redhat.com> (raw)
In-Reply-To: <20140818091239.GD25495@gmail.com>
On Mon, Aug 18, 2014 at 11:12:39AM +0200, Ingo Molnar wrote:
>
> * Don Zickus <dzickus@redhat.com> wrote:
>
> > From: Ulrich Obergfell <uobergfe@redhat.com>
> >
> > In some cases we don't want hard lockup detection enabled by default.
> > An example is when running as a guest. Introduce
> >
> > watchdog_enable_hardlockup_detector(bool)
>
> So, the name watchdog_enable_hardlockup_detector_enable(false)
> is both too long and also really confusing (because first it
> suggests enablement, then disables it), so I renamed it to
> hardlockup_detector_set(), which allows two natural variants:
>
> hardlockup_detector_set(false);
> ...
> hardlockup_detector_set(true);
Fair enough. Thanks!
Cheers,
Don
next prev parent reply other threads:[~2014-08-18 15:07 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-11 14:49 [PATCH 0/5] watchdog: various fixes Don Zickus
2014-08-11 14:49 ` [PATCH 1/5] watchdog: remove unnecessary head files Don Zickus
2014-08-18 18:03 ` [tip:perf/watchdog] watchdog: Remove unnecessary header files tip-bot for chai wen
2014-08-11 14:49 ` [PATCH 2/5] softlockup: make detector be aware of task switch of processes hogging cpu Don Zickus
2014-08-18 9:03 ` Ingo Molnar
2014-08-18 15:06 ` Don Zickus
2014-08-18 18:01 ` Ingo Molnar
2014-08-18 18:43 ` Don Zickus
2014-08-18 19:02 ` Ingo Molnar
2014-08-18 20:38 ` Don Zickus
2014-08-19 1:36 ` Chai Wen
2014-08-21 1:37 ` Chai Wen
2014-08-21 2:30 ` Don Zickus
2014-08-21 5:42 ` [PATCH] " chai wen
2014-08-22 1:12 ` Chai Wen
2014-08-22 1:58 ` Don Zickus
2014-08-26 12:51 ` Chai Wen
2014-08-26 14:22 ` Don Zickus
2014-08-27 1:33 ` Chai Wen
2014-08-11 14:49 ` [PATCH 3/5] watchdog: fix print-once on enable Don Zickus
2014-08-18 9:05 ` Ingo Molnar
2014-08-18 9:07 ` Ingo Molnar
2014-08-18 15:07 ` Don Zickus
2014-08-18 18:03 ` [tip:perf/watchdog] watchdog: Fix " tip-bot for Ulrich Obergfell
2014-08-11 14:49 ` [PATCH 4/5] watchdog: control hard lockup detection default Don Zickus
2014-08-18 9:12 ` Ingo Molnar
2014-08-18 15:07 ` Don Zickus [this message]
2014-08-18 9:16 ` Ingo Molnar
2014-08-18 10:44 ` Ulrich Obergfell
2014-08-18 15:17 ` Don Zickus
2014-08-18 18:07 ` Ingo Molnar
2014-08-18 18:53 ` Don Zickus
2014-08-18 19:00 ` Ingo Molnar
2014-08-11 14:49 ` [PATCH 5/5] kvm: ensure hard lockup detection is disabled by default Don Zickus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140818150752.GS49576@redhat.com \
--to=dzickus@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=uobergfe@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).