public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3] powerpc/perf: Implement get_cpu_str()
@ 2014-08-19  0:08 Sukadev Bhattiprolu
  2014-08-20  6:21 ` Michael Ellerman
  0 siblings, 1 reply; 2+ messages in thread
From: Sukadev Bhattiprolu @ 2014-08-19  0:08 UTC (permalink / raw)
  To: Jiri Olsa, Arnaldo Carvalho de Melo; +Cc: linux-kernel

powerpc/perf: Implement get_cpu_str()

With a file ~/.cache/pmu-events/004d0100-core.json describing Power8
PMU events we would need to run:

	perf stat \
		--events-file ~/.cache/pmu-events/004d0100-core.json \
		-e PM_CYC sleep 1

With this get_cpu_str(), On Powerpc, we can skip the --events-file option
and run:

	perf stat -e PM_CYC sleep 1

Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
---
Changelog[v3]:
        [Tobias Klauser]: Fix some changelog damage to patch.

Changelog[v2]:
	[Michael Ellerman]: Use PVR instead of AUXV variables

 tools/perf/arch/powerpc/util/header.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/tools/perf/arch/powerpc/util/header.c b/tools/perf/arch/powerpc/util/header.c
index 6c1b8a7..306bf35 100644
--- a/tools/perf/arch/powerpc/util/header.c
+++ b/tools/perf/arch/powerpc/util/header.c
@@ -6,6 +6,7 @@
 
 #include "../../util/header.h"
 #include "../../util/util.h"
+#include "../../util/jevents.h"
 
 #define mfspr(rn)       ({unsigned long rval; \
 			 asm volatile("mfspr %0," __stringify(rn) \
@@ -32,3 +33,14 @@ get_cpuid(char *buffer, size_t sz)
 	}
 	return -1;
 }
+
+char *
+get_cpu_str(void)
+{
+	char *bufp;
+
+	if (asprintf(&bufp, "%.8lx-core", mfspr(SPRN_PVR)) < 0)
+		bufp = NULL;
+
+	return bufp;
+}
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v3] powerpc/perf: Implement get_cpu_str()
  2014-08-19  0:08 [PATCH v3] powerpc/perf: Implement get_cpu_str() Sukadev Bhattiprolu
@ 2014-08-20  6:21 ` Michael Ellerman
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2014-08-20  6:21 UTC (permalink / raw)
  To: Sukadev Bhattiprolu; +Cc: Jiri Olsa, Arnaldo Carvalho de Melo, linux-kernel

On Mon, 2014-08-18 at 17:08 -0700, Sukadev Bhattiprolu wrote:
> powerpc/perf: Implement get_cpu_str()
> 
> With a file ~/.cache/pmu-events/004d0100-core.json describing Power8
> PMU events we would need to run:
> 
> 	perf stat \
> 		--events-file ~/.cache/pmu-events/004d0100-core.json \
> 		-e PM_CYC sleep 1
> 
> With this get_cpu_str(), On Powerpc, we can skip the --events-file option
> and run:
> 
> 	perf stat -e PM_CYC sleep 1
> 
> Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>

Acked-by: Michael Ellerman <mpe@ellerman.id.au>

cheers





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-08-20  6:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-19  0:08 [PATCH v3] powerpc/perf: Implement get_cpu_str() Sukadev Bhattiprolu
2014-08-20  6:21 ` Michael Ellerman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox