From: Andrew Vagin <avagin@parallels.com>
To: Manfred Spraul <manfred@colorfullife.com>
Cc: Andrey Vagin <avagin@openvz.org>, <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Mathias Krause <minipli@googlemail.com>,
Joe Perches <joe@perches.com>, Davidlohr Bueso <davidlohr@hp.com>
Subject: Re: [PATCH] ipc: always handle a new value of auto_msgmni
Date: Tue, 19 Aug 2014 10:42:55 +0400 [thread overview]
Message-ID: <20140819064255.GA14360@paralelels.com> (raw)
In-Reply-To: <53EFBF1C.5060407@colorfullife.com>
On Sat, Aug 16, 2014 at 10:29:16PM +0200, Manfred Spraul wrote:
> Hi Andrew,
>
> On 08/14/2014 03:34 PM, Andrew Vagin wrote:
> >On Thu, Aug 14, 2014 at 11:37:45AM +0200, Manfred Spraul wrote:
> >>Hi Andrey,
> >>
> >>[...]
> >>What do you use auto_msgmni for?
> >We disable it to check that criu restores a value of the msgmni sysctl correctly.
> >
> >https://github.com/xemul/criu/blob/master/test/zdtm/live/static/ipc_namespace.c
> Thanks for the link, if I see it right, my patch would break your code:
>
> http://marc.info/?l=linux-kernel&m=140782863804950
>
> It removes auto_msgmni - and
> What do you think, should I leave auto_msgmni as a stale variable, perhaps
> with a pr_info() that it doesn't have any effect?
Yes, you should. For example "criu restore" will start failing, if you remove
auto_msgmni.
>
>
> --
> Manfred
prev parent reply other threads:[~2014-08-19 6:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 13:21 [PATCH] ipc: always handle a new value of auto_msgmni Andrey Vagin
2014-08-14 9:37 ` Manfred Spraul
2014-08-14 13:34 ` Andrew Vagin
2014-08-16 20:29 ` Manfred Spraul
2014-08-19 6:42 ` Andrew Vagin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140819064255.GA14360@paralelels.com \
--to=avagin@parallels.com \
--cc=akpm@linux-foundation.org \
--cc=avagin@openvz.org \
--cc=davidlohr@hp.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=minipli@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox