From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753896AbaHSS44 (ORCPT ); Tue, 19 Aug 2014 14:56:56 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:62644 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753730AbaHSS4y (ORCPT ); Tue, 19 Aug 2014 14:56:54 -0400 Date: Tue, 19 Aug 2014 11:56:40 -0700 From: Dmitry Torokhov To: linux-input@vger.kernel.org Cc: Nick Dyer , Stephen Warren , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Input: atmel_mxt_ts - remove unneeded check Message-ID: <20140819185639.GA26302@core.coreip.homeip.net> References: <20140817142851.GA21153@core.coreip.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140817142851.GA21153@core.coreip.homeip.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Aug 17, 2014 at 07:28:52AM -0700, Dmitry Torokhov wrote: > This fixes the following issue reported by Coverity: > > ** CID 1231785: Unsigned compared against 0 (NO_EFFECT) > /drivers/input/touchscreen/atmel_mxt_ts.c: 1157 in mxt_prepare_cfg_mem() > > The variable 'byte_offset' is declared as unsigned int and therefore can never > be less than 0. > Withdrawn - Linus recommended to become intimate with the compiler instead. > Signed-off-by: Dmitry Torokhov > --- > drivers/input/touchscreen/atmel_mxt_ts.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c > index db178ed..8780c9a 100644 > --- a/drivers/input/touchscreen/atmel_mxt_ts.c > +++ b/drivers/input/touchscreen/atmel_mxt_ts.c > @@ -1154,7 +1154,7 @@ static int mxt_prepare_cfg_mem(struct mxt_data *data, > > byte_offset = reg + i - cfg_start_ofs; > > - if (byte_offset >= 0 && byte_offset < config_mem_size) { > + if (byte_offset < config_mem_size) { > *(config_mem + byte_offset) = val; > } else { > dev_err(dev, "Bad object: reg:%d, T%d, ofs=%d\n", > -- > 2.1.0.rc2.206.gedb03e5 > > > -- > Dmitry -- Dmitry