From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751956AbaHTLQT (ORCPT ); Wed, 20 Aug 2014 07:16:19 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:35708 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751626AbaHTLQS (ORCPT ); Wed, 20 Aug 2014 07:16:18 -0400 Date: Wed, 20 Aug 2014 06:15:37 -0500 From: gregkh To: sanjeev sharma Cc: Lars-Peter Clausen , Sanjeev Sharma , jic23@kernel.org, linux-iio@vger.kernel.org, devel , linux-kernel Subject: Re: [PATCH] staging:iio: moved platform_data into include/linux/iio Message-ID: <20140820111537.GA12663@kroah.com> References: <1408516869-6099-1-git-send-email-sanjeev_sharma@mentor.com> <53F441FF.9090304@metafoo.de> <53F4451B.3040209@metafoo.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Wed, Aug 20, 2014 at 12:32:52PM +0530, sanjeev sharma wrote: > Hi, > > I have only moved some header files because other header files are already > present there and these are only pending files which is not moved outside the > staging directory. > > @Greg:What is your though on this ? Lars-Peter is correct, don't "leak" files from staging. Take the time to work on fixing up these drivers correctly so they can be moved out of staging instead of just doing simple file moves which do nothing. greg k-h