From: Hoang Tran <hoangtran.gwr@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Larry Finger <Larry.Finger@lwfinger.net>,
Sachin Kamat <sachin.kamat@linaro.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8821ae: fix sparse warning for static declarations in rtl8821ae/stats.c
Date: Wed, 20 Aug 2014 19:43:48 +0800 [thread overview]
Message-ID: <20140820114348.GA28381@funtoo.greenwavereality.com> (raw)
In-Reply-To: <20140820111916.GA12812@kroah.com>
On Aug 20, 2014 at 06:19am, Greg Kroah-Hartman wrote:
> On Wed, Aug 20, 2014 at 04:53:22PM +0800, Hoang Tran wrote:
> > This patch fixes the following sparse warnings in rtl8821ae/stats.c
> >
> > drivers/staging/rtl8821ae/stats.c:62:6: warning: symbol 'rtl_translate_todbm' was not declared. Should it be static?
> > drivers/staging/rtl8821ae/stats.c:101:6: warning: symbol 'rtl_process_ui_rssi' was not declared. Should it be static?
> >
> > Signed-off-by: Hoang Tran <hoangtran.gwr@gmail.com>
> > ---
> > drivers/staging/rtl8821ae/stats.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
>
> You sent 2 patches that look to do the same thing, but are different, so
> I have no idea which to apply. Always properly "version" your patches
> so as to not confuse easily-confused maintainers.
>
Thanks, I resent the patch here https://lkml.org/lkml/2014/8/20/246
> I've dropped both of these, please resend the one you really want to
> be
> considered.
>
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2014-08-20 11:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-20 8:53 [PATCH] staging: rtl8821ae: fix sparse warning for static declarations in rtl8821ae/stats.c Hoang Tran
2014-08-20 11:19 ` Greg Kroah-Hartman
2014-08-20 11:43 ` Hoang Tran [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-08-20 8:48 Hoang Tran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140820114348.GA28381@funtoo.greenwavereality.com \
--to=hoangtran.gwr@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox