[PATCH] staging: rtl8821ae: fix sparse warning for static declarations in rtl8821ae/stats.c

[PATCH] staging: rtl8821ae: fix sparse warning for static declarations in rtl8821ae/stats.c

[Hoang Tran]

This patch fixes the following sparse warnings in rtl8821ae/stats.c

drivers/staging/rtl8821ae/stats.c:62:6: warning: symbol 'rtl_translate_todbm' was not declared. Should it be static?
drivers/staging/rtl8821ae/stats.c:101:6: warning: symbol 'rtl_process_ui_rssi' was not declared. Should it be static?

Signed-off-by: Hoang Tran <hoangtran.gwr@gmail.com>
---
 drivers/staging/rtl8821ae/stats.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8821ae/stats.c b/drivers/staging/rtl8821ae/stats.c
index 4d383d1..556d1ac 100644
--- a/drivers/staging/rtl8821ae/stats.c
+++ b/drivers/staging/rtl8821ae/stats.c
@@ -59,7 +59,7 @@ u8 rtl_evm_db_to_percentage(char value)
 }
 //EXPORT_SYMBOL(rtl_evm_db_to_percentage);
 
-long rtl_translate_todbm(struct ieee80211_hw *hw,
+static long rtl_translate_todbm(struct ieee80211_hw *hw,
 			 u8 signal_strength_index)
 {
 	long signal_power;
@@ -98,7 +98,7 @@ long rtl_signal_scale_mapping(struct ieee80211_hw *hw, long currsig)
 }
 //EXPORT_SYMBOL(rtl_signal_scale_mapping);
 
-void rtl_process_ui_rssi(struct ieee80211_hw *hw, struct rtl_stats *pstatus)
+static void rtl_process_ui_rssi(struct ieee80211_hw *hw, struct rtl_stats *pstatus)
 {
 	struct rtl_priv *rtlpriv = rtl_priv(hw);
 	struct rtl_phy *rtlphy = &(rtlpriv->phy);
-- 
2.0.2

[PATCH] staging: rtl8821ae: fix sparse warning for static declarations in rtl8821ae/stats.c

[Hoang Tran]

This patch fixes the following sparse warnings in rtl8821ae/stats.c

drivers/staging/rtl8821ae/stats.c:62:6: warning: symbol 'rtl_translate_todbm' was not declared. Should it be static?
drivers/staging/rtl8821ae/stats.c:101:6: warning: symbol 'rtl_process_ui_rssi' was not declared. Should it be static?

Signed-off-by: Hoang Tran <hoangtran.gwr@gmail.com>
---
 drivers/staging/rtl8821ae/stats.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8821ae/stats.c b/drivers/staging/rtl8821ae/stats.c
index 4d383d1..fdbde43 100644
--- a/drivers/staging/rtl8821ae/stats.c
+++ b/drivers/staging/rtl8821ae/stats.c
@@ -59,7 +59,7 @@ u8 rtl_evm_db_to_percentage(char value)
 }
 //EXPORT_SYMBOL(rtl_evm_db_to_percentage);
 
-long rtl_translate_todbm(struct ieee80211_hw *hw,
+static long rtl_translate_todbm(struct ieee80211_hw *hw,
 			 u8 signal_strength_index)
 {
 	long signal_power;
@@ -98,7 +98,8 @@ long rtl_signal_scale_mapping(struct ieee80211_hw *hw, long currsig)
 }
 //EXPORT_SYMBOL(rtl_signal_scale_mapping);
 
-void rtl_process_ui_rssi(struct ieee80211_hw *hw, struct rtl_stats *pstatus)
+static void rtl_process_ui_rssi(struct ieee80211_hw *hw,
+				struct rtl_stats *pstatus)
 {
 	struct rtl_priv *rtlpriv = rtl_priv(hw);
 	struct rtl_phy *rtlphy = &(rtlpriv->phy);
-- 
2.0.2

Re: [PATCH] staging: rtl8821ae: fix sparse warning for static declarations in rtl8821ae/stats.c

[Greg Kroah-Hartman]

On Wed, Aug 20, 2014 at 04:53:22PM +0800, Hoang Tran wrote:
> This patch fixes the following sparse warnings in rtl8821ae/stats.c
> 
> drivers/staging/rtl8821ae/stats.c:62:6: warning: symbol 'rtl_translate_todbm' was not declared. Should it be static?
> drivers/staging/rtl8821ae/stats.c:101:6: warning: symbol 'rtl_process_ui_rssi' was not declared. Should it be static?
> 
> Signed-off-by: Hoang Tran <hoangtran.gwr@gmail.com>
> ---
>  drivers/staging/rtl8821ae/stats.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

You sent 2 patches that look to do the same thing, but are different, so
I have no idea which to apply.  Always properly "version" your patches
so as to not confuse easily-confused maintainers.

I've dropped both of these, please resend the one you really want to be
considered.

thanks,

greg k-h

Re: [PATCH] staging: rtl8821ae: fix sparse warning for static declarations in rtl8821ae/stats.c

[Hoang Tran]

On Aug 20, 2014 at 06:19am, Greg Kroah-Hartman wrote:
> On Wed, Aug 20, 2014 at 04:53:22PM +0800, Hoang Tran wrote:
> > This patch fixes the following sparse warnings in rtl8821ae/stats.c
> > 
> > drivers/staging/rtl8821ae/stats.c:62:6: warning: symbol 'rtl_translate_todbm' was not declared. Should it be static?
> > drivers/staging/rtl8821ae/stats.c:101:6: warning: symbol 'rtl_process_ui_rssi' was not declared. Should it be static?
> > 
> > Signed-off-by: Hoang Tran <hoangtran.gwr@gmail.com>
> > ---
> >  drivers/staging/rtl8821ae/stats.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> You sent 2 patches that look to do the same thing, but are different, so
> I have no idea which to apply.  Always properly "version" your patches
> so as to not confuse easily-confused maintainers.
> 

Thanks, I resent the patch here https://lkml.org/lkml/2014/8/20/246

> I've dropped both of these, please resend the one you really want to 
> be
> considered.
> 
> thanks,
> 
> greg k-h