* [PATCH v2] flush_icache_range: Export symbol to fix build errors
@ 2014-08-18 15:59 Pranith Kumar
2014-08-18 16:22 ` Max Filippov
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Pranith Kumar @ 2014-08-18 15:59 UTC (permalink / raw)
To: Vineet Gupta, Richard Kuo, Chris Metcalf, Chris Zankel,
Max Filippov, Noam Camus, Andrew Morton, Geert Uytterhoeven,
Masami Hiramatsu, Tony Lu, Kirill Tkhai, open list,
open list:QUALCOMM HEXAGON..., open list:SUPERH,
open list:TENSILICA XTENSA...
Fix building errors occuring due to a missing export of flush_icache_range() in
kisskb.ellerman.id.au/kisskb/buildresult/11677809/
ERROR: "flush_icache_range" [drivers/misc/lkdtm.ko] undefined!
Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
CC: Andrew Morton <akpm@linux-foundation.org>
---
arch/arc/mm/cache_arc700.c | 1 +
arch/hexagon/mm/cache.c | 1 +
arch/sh/mm/cache.c | 1 +
arch/tile/kernel/smp.c | 1 +
arch/xtensa/kernel/smp.c | 1 +
5 files changed, 5 insertions(+)
diff --git a/arch/arc/mm/cache_arc700.c b/arch/arc/mm/cache_arc700.c
index 4670afc..e88ddbf 100644
--- a/arch/arc/mm/cache_arc700.c
+++ b/arch/arc/mm/cache_arc700.c
@@ -581,6 +581,7 @@ void flush_icache_range(unsigned long kstart, unsigned long kend)
tot_sz -= sz;
}
}
+EXPORT_SYMBOL(flush_icache_range);
/*
* General purpose helper to make I and D cache lines consistent.
diff --git a/arch/hexagon/mm/cache.c b/arch/hexagon/mm/cache.c
index fe14ccf..0c76c80 100644
--- a/arch/hexagon/mm/cache.c
+++ b/arch/hexagon/mm/cache.c
@@ -68,6 +68,7 @@ void flush_icache_range(unsigned long start, unsigned long end)
);
local_irq_restore(flags);
}
+EXPORT_SYMBOL(flush_icache_range);
void hexagon_clean_dcache_range(unsigned long start, unsigned long end)
{
diff --git a/arch/sh/mm/cache.c b/arch/sh/mm/cache.c
index 097c2cd..f770e39 100644
--- a/arch/sh/mm/cache.c
+++ b/arch/sh/mm/cache.c
@@ -229,6 +229,7 @@ void flush_icache_range(unsigned long start, unsigned long end)
cacheop_on_each_cpu(local_flush_icache_range, (void *)&data, 1);
}
+EXPORT_SYMBOL(flush_icache_range);
void flush_icache_page(struct vm_area_struct *vma, struct page *page)
{
diff --git a/arch/tile/kernel/smp.c b/arch/tile/kernel/smp.c
index 01e8ab2..19eaa62 100644
--- a/arch/tile/kernel/smp.c
+++ b/arch/tile/kernel/smp.c
@@ -183,6 +183,7 @@ void flush_icache_range(unsigned long start, unsigned long end)
preempt_enable();
}
}
+EXPORT_SYMBOL(flush_icache_range);
/* Called when smp_send_reschedule() triggers IRQ_RESCHEDULE. */
diff --git a/arch/xtensa/kernel/smp.c b/arch/xtensa/kernel/smp.c
index 40b5a37..4d02e38 100644
--- a/arch/xtensa/kernel/smp.c
+++ b/arch/xtensa/kernel/smp.c
@@ -571,6 +571,7 @@ void flush_icache_range(unsigned long start, unsigned long end)
};
on_each_cpu(ipi_flush_icache_range, &fd, 1);
}
+EXPORT_SYMBOL(flush_icache_range);
/* ------------------------------------------------------------------------- */
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] flush_icache_range: Export symbol to fix build errors
2014-08-18 15:59 [PATCH v2] flush_icache_range: Export symbol to fix build errors Pranith Kumar
@ 2014-08-18 16:22 ` Max Filippov
2014-08-20 16:34 ` Vineet Gupta
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Max Filippov @ 2014-08-18 16:22 UTC (permalink / raw)
To: Pranith Kumar
Cc: Vineet Gupta, Richard Kuo, Chris Metcalf, Chris Zankel,
Noam Camus, Andrew Morton, Geert Uytterhoeven, Masami Hiramatsu,
Tony Lu, Kirill Tkhai, open list, open list:QUALCOMM HEXAGON...,
open list:SUPERH, open list:TENSILICA XTENSA...
On Mon, Aug 18, 2014 at 7:59 PM, Pranith Kumar <bobby.prani@gmail.com> wrote:
> Fix building errors occuring due to a missing export of flush_icache_range() in
>
> kisskb.ellerman.id.au/kisskb/buildresult/11677809/
>
> ERROR: "flush_icache_range" [drivers/misc/lkdtm.ko] undefined!
>
> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> CC: Andrew Morton <akpm@linux-foundation.org>
> ---
> arch/arc/mm/cache_arc700.c | 1 +
> arch/hexagon/mm/cache.c | 1 +
> arch/sh/mm/cache.c | 1 +
> arch/tile/kernel/smp.c | 1 +
> arch/xtensa/kernel/smp.c | 1 +
> 5 files changed, 5 insertions(+)
For xtensa
Acked-by: Max Filippov <jcmvbkbc@gmail.com>
--
Thanks.
-- Max
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] flush_icache_range: Export symbol to fix build errors
2014-08-18 15:59 [PATCH v2] flush_icache_range: Export symbol to fix build errors Pranith Kumar
2014-08-18 16:22 ` Max Filippov
@ 2014-08-20 16:34 ` Vineet Gupta
2014-08-21 0:06 ` rkuo
2014-08-21 2:40 ` Tony Lu
3 siblings, 0 replies; 5+ messages in thread
From: Vineet Gupta @ 2014-08-20 16:34 UTC (permalink / raw)
To: Pranith Kumar, Richard Kuo, Chris Metcalf, Chris Zankel,
Max Filippov, Noam Camus, Andrew Morton, Geert Uytterhoeven,
Masami Hiramatsu, Tony Lu, Kirill Tkhai, open list,
open list:QUALCOMM HEXAGON..., open list:SUPERH,
open list:TENSILICA XTENSA...
On Monday 18 August 2014 08:59 AM, Pranith Kumar wrote:
> Fix building errors occuring due to a missing export of flush_icache_range() in
>
> kisskb.ellerman.id.au/kisskb/buildresult/11677809/
>
> ERROR: "flush_icache_range" [drivers/misc/lkdtm.ko] undefined!
>
> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> CC: Andrew Morton <akpm@linux-foundation.org>
> ---
> arch/arc/mm/cache_arc700.c | 1 +
> arch/hexagon/mm/cache.c | 1 +
> arch/sh/mm/cache.c | 1 +
> arch/tile/kernel/smp.c | 1 +
> arch/xtensa/kernel/smp.c | 1 +
> 5 files changed, 5 insertions(+)
>
> diff --git a/arch/arc/mm/cache_arc700.c b/arch/arc/mm/cache_arc700.c
> index 4670afc..e88ddbf 100644
> --- a/arch/arc/mm/cache_arc700.c
> +++ b/arch/arc/mm/cache_arc700.c
> @@ -581,6 +581,7 @@ void flush_icache_range(unsigned long kstart, unsigned long kend)
> tot_sz -= sz;
> }
> }
> +EXPORT_SYMBOL(flush_icache_range);
Acked-by: Vineet Gupta <vgupta@synopsys.com> # for arch/arc bits
thx,
-Vineet
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] flush_icache_range: Export symbol to fix build errors
2014-08-18 15:59 [PATCH v2] flush_icache_range: Export symbol to fix build errors Pranith Kumar
2014-08-18 16:22 ` Max Filippov
2014-08-20 16:34 ` Vineet Gupta
@ 2014-08-21 0:06 ` rkuo
2014-08-21 2:40 ` Tony Lu
3 siblings, 0 replies; 5+ messages in thread
From: rkuo @ 2014-08-21 0:06 UTC (permalink / raw)
To: Pranith Kumar
Cc: Vineet Gupta, Chris Metcalf, Chris Zankel, Max Filippov,
Noam Camus, Andrew Morton, Geert Uytterhoeven, Masami Hiramatsu,
Tony Lu, Kirill Tkhai, open list, open list:QUALCOMM HEXAGON...,
open list:SUPERH, open list:TENSILICA XTENSA...
On Mon, Aug 18, 2014 at 11:59:13AM -0400, Pranith Kumar wrote:
> Fix building errors occuring due to a missing export of flush_icache_range() in
>
> kisskb.ellerman.id.au/kisskb/buildresult/11677809/
>
> ERROR: "flush_icache_range" [drivers/misc/lkdtm.ko] undefined!
>
> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> CC: Andrew Morton <akpm@linux-foundation.org>
> ---
> arch/arc/mm/cache_arc700.c | 1 +
> arch/hexagon/mm/cache.c | 1 +
> arch/sh/mm/cache.c | 1 +
> arch/tile/kernel/smp.c | 1 +
> arch/xtensa/kernel/smp.c | 1 +
> 5 files changed, 5 insertions(+)
>
For Hexagon,
Acked-by: Richard Kuo <rkuo@codeaurora.org>
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH v2] flush_icache_range: Export symbol to fix build errors
2014-08-18 15:59 [PATCH v2] flush_icache_range: Export symbol to fix build errors Pranith Kumar
` (2 preceding siblings ...)
2014-08-21 0:06 ` rkuo
@ 2014-08-21 2:40 ` Tony Lu
3 siblings, 0 replies; 5+ messages in thread
From: Tony Lu @ 2014-08-21 2:40 UTC (permalink / raw)
To: Pranith Kumar, Vineet Gupta, Richard Kuo, Chris Metcalf,
Chris Zankel, Max Filippov, Noam Camus, Andrew Morton,
Geert Uytterhoeven, Masami Hiramatsu, Kirill Tkhai, open list,
open list:QUALCOMM HEXAGON..., open list:SUPERH,
open list:TENSILICA XTENSA...
>-----Original Message-----
>Fix building errors occuring due to a missing export of flush_icache_range()
>in
>
>kisskb.ellerman.id.au/kisskb/buildresult/11677809/
>
>ERROR: "flush_icache_range" [drivers/misc/lkdtm.ko] undefined!
>
>Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
>Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
>CC: Andrew Morton <akpm@linux-foundation.org>
>---
> arch/arc/mm/cache_arc700.c | 1 +
> arch/hexagon/mm/cache.c | 1 +
> arch/sh/mm/cache.c | 1 +
> arch/tile/kernel/smp.c | 1 +
> arch/xtensa/kernel/smp.c | 1 +
> 5 files changed, 5 insertions(+)
>
For Tile,
Acked-by: Zhigang Lu <zlu@tilera.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-08-21 2:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-18 15:59 [PATCH v2] flush_icache_range: Export symbol to fix build errors Pranith Kumar
2014-08-18 16:22 ` Max Filippov
2014-08-20 16:34 ` Vineet Gupta
2014-08-21 0:06 ` rkuo
2014-08-21 2:40 ` Tony Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox