From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754631AbaHULay (ORCPT ); Thu, 21 Aug 2014 07:30:54 -0400 Received: from mail-ig0-f172.google.com ([209.85.213.172]:57288 "EHLO mail-ig0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754222AbaHULaw (ORCPT ); Thu, 21 Aug 2014 07:30:52 -0400 Date: Thu, 21 Aug 2014 12:30:46 +0100 From: Lee Jones To: Andreas Werner Cc: linux-kernel@vger.kernel.org, sameo@linux.intel.com, wim@iguana.be, linux-watchdog@vger.kernel.org, cooloney@gmail.com, rpurdie@rpsys.net, linux-leds@vger.kernel.org, jdelvare@suse.de, linux@roeck-us.net, lm-sensors@lm-sensors.org Subject: Re: [PATCH v4 1/4] drivers/mfd/menf21bmc: introduce MEN 14F021P00 BMC MFD Core driver Message-ID: <20140821113046.GZ4266@lee--X1> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 13 Aug 2014, Andreas Werner wrote: > The MEN 14F021P00 Board Management Controller provides an > I2C interface to the host to access the feature implemented in the BMC. > The BMC is a PIC Microntroller assembled on CPCI Card from MEN Mikroelektronik > and on a few Box/Display Computer. > > Added MFD Core driver, supporting the I2C communication to the device. > > The MFD driver currently supports the following features: > - Watchdog > - LEDs > - Hwmon (voltage monitoring) > > Signed-off-by: Andreas Werner > --- > drivers/mfd/Kconfig | 12 +++++ > drivers/mfd/Makefile | 1 + > drivers/mfd/menf21bmc.c | 132 ++++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 145 insertions(+) > create mode 100644 drivers/mfd/menf21bmc.c > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index b8d9ca0..bf155b9 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -453,6 +453,18 @@ config MFD_MAX8998 > additional drivers must be enabled in order to use the functionality > of the device. > > +config MFD_MENF21BMC > + tristate "MEN 14F021P00 Board Management Controller Support" > + depends on I2C=y Why must I2C be built-in? > + select MFD_CORE > + help > + Say yes here to add support for the MEN 14F021P00 BMC > + which is a Board Management Controller connected to the I2C bus. > + The device supports multiple sub-devices like LED, HWMON and WDT. > + This driver provides common support for accessing the devices; > + additional drivers must be enabled in order to use the > + functionality of the BMC device. > + Apart from that the patch looks good to me. I'm assuming this can go in via the MFD tree by itself? Acked-by: Lee Jones -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog