From: Lee Jones <lee.jones@linaro.org>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: sameo@linux.intel.com, patches@opensource.wolfsonmicro.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] mfd: arizona: Propagate irq_wake through to parent IRQ
Date: Thu, 21 Aug 2014 12:57:50 +0100 [thread overview]
Message-ID: <20140821115750.GB4266@lee--X1> (raw)
In-Reply-To: <1407851483-19207-2-git-send-email-ckeepax@opensource.wolfsonmicro.com>
On Tue, 12 Aug 2014, Charles Keepax wrote:
> If one of the internal Arizona IRQs is set as a wake source this needs
> to be propogated back to the actual IRQ line that the Arizona device is
> attached to.
>
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
> drivers/mfd/arizona-irq.c | 8 ++++++++
> 1 files changed, 8 insertions(+), 0 deletions(-)
Acked-by: Lee Jones <lee.jones@linaro.org>
... but obviously this won't apply, as it's based on the previous
NACKed patch.
> diff --git a/drivers/mfd/arizona-irq.c b/drivers/mfd/arizona-irq.c
> index 71e8f06..fac00b2 100644
> --- a/drivers/mfd/arizona-irq.c
> +++ b/drivers/mfd/arizona-irq.c
> @@ -148,6 +148,13 @@ static void arizona_irq_dummy(struct irq_data *data)
> {
> }
>
> +static int arizona_irq_set_wake(struct irq_data *data, unsigned int on)
> +{
> + struct arizona *arizona = irq_data_get_irq_chip_data(data);
> +
> + return irq_set_irq_wake(arizona->irq, on);
> +}
> +
> static struct irq_chip arizona_irq_chip = {
> .name = "arizona",
> .irq_disable = arizona_irq_dummy,
> @@ -155,6 +162,7 @@ static struct irq_chip arizona_irq_chip = {
> .irq_ack = arizona_irq_dummy,
> .irq_mask = arizona_irq_dummy,
> .irq_unmask = arizona_irq_dummy,
> + .irq_set_wake = arizona_irq_set_wake,
> };
>
> static int arizona_irq_map(struct irq_domain *h, unsigned int virq,
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-08-21 11:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-12 13:51 [PATCH 1/4] mfd: arizona: Add additional dummy IRQ callbacks Charles Keepax
2014-08-12 13:51 ` [PATCH 2/4] mfd: arizona: Propagate irq_wake through to parent IRQ Charles Keepax
2014-08-21 11:57 ` Lee Jones [this message]
2014-08-12 13:51 ` [PATCH 3/4] mfd: arizona: Avoid use of legacy IRQ mapping Charles Keepax
2014-08-21 11:59 ` Lee Jones
2014-08-12 13:51 ` [PATCH 4/4] mfd: arizona: Mark additional registers as volatile Charles Keepax
2014-08-13 9:22 ` Charles Keepax
2014-08-21 11:56 ` [PATCH 1/4] mfd: arizona: Add additional dummy IRQ callbacks Lee Jones
2014-08-21 12:05 ` Charles Keepax
2014-09-02 14:09 ` Charles Keepax
2014-09-02 14:26 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140821115750.GB4266@lee--X1 \
--to=lee.jones@linaro.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox