Re: [PATCH 1/4] mfd: menelaus: fix error return code

[Lee Jones <lee.jones@linaro.org>]

On Thu, 21 Aug 2014, Julia Lawall wrote:

> Convert a zero return value on error to a negative one, as returned
> elsewhere in the function.
> 
> Additionally, converted 1 << 7 to BIT(7) at the suggestion of Lee Jones.
> 
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> (
> if@p1 (\(ret < 0\|ret != 0\))
>  { ... return ret; }
> |
> ret@p1 = 0
> )
> ... when != ret = e1
>     when != &ret
> *if(...)
> {
>   ... when != ret = e2
>       when forall
>  return ret;
> }
> 
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> ---
> v2: Drop the name "val" and use BIT(7).

Thanks Julia.  Patch applied.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog