From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Gleb Natapov <gleb@kernel.org>,
Raghavendra KT <raghavendra.kt@linux.vnet.ibm.com>,
Vinod Chegu <chegu_vinod@hp.com>, Hui-Zhi <hui-zhi.zhao@hp.com>,
Christian Borntraeger <borntraeger@de.ibm.com>
Subject: Re: [PATCH v2 5/6] KVM: trace kvm_ple_window
Date: Thu, 21 Aug 2014 15:49:17 +0200 [thread overview]
Message-ID: <20140821134916.GF20453@potion.brq.redhat.com> (raw)
In-Reply-To: <53F5F2AA.7060600@redhat.com>
2014-08-21 15:22+0200, Paolo Bonzini:
> Il 21/08/2014 13:56, Radim Krčmář ha scritto:
> > 2014-08-21 10:29+0200, Paolo Bonzini:
> >> Il 20/08/2014 22:53, Radim Krčmář ha scritto:
> >>> + TP_PROTO(int grow, unsigned int vcpu_id, int new, int old),
> >>
> >> s/int grow/bool grow/ (and similarly in TP_STRUCT__entry).
> >
> > Ok.
> > (We are using 'int' for this in other tracepoints, so I guessed there is
> > some hate agains bool.)
>
> Yeah, there are many ints, but there are also some bools. :)
>
> Of course "bool" is only a no-brainer if there is a clear direction to
> use (e.g. "bool has_error"), and indeed this case is less obvious. But
> there are some like this one (e.g. bool gpa_match).
>
> Keep the int if you prefer it that way.
I actually like bool much better, but first few were only int and then I
stopped looking ...
next prev parent reply other threads:[~2014-08-21 13:49 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-20 20:53 [PATCH v2 0/6] Dynamic Pause Loop Exiting window Radim Krčmář
2014-08-20 20:53 ` [PATCH v2 1/6] KVM: add kvm_arch_sched_in Radim Krčmář
2014-08-21 8:29 ` Paolo Bonzini
2014-08-21 11:38 ` Radim Krčmář
2014-08-21 12:27 ` Paolo Bonzini
2014-08-21 12:50 ` Radim Krčmář
2014-08-21 13:25 ` Paolo Bonzini
2014-08-20 20:53 ` [PATCH v2 2/6] KVM: x86: introduce sched_in to kvm_x86_ops Radim Krčmář
2014-08-20 20:53 ` [PATCH v2 3/6] KVM: VMX: make PLE window per-VCPU Radim Krčmář
2014-08-21 8:25 ` Paolo Bonzini
2014-08-21 11:38 ` Radim Krčmář
2014-08-20 20:53 ` [PATCH v2 4/6] KVM: VMX: dynamise PLE window Radim Krčmář
2014-08-21 8:24 ` Paolo Bonzini
2014-08-21 11:47 ` Radim Krčmář
2014-08-21 8:26 ` Paolo Bonzini
2014-08-21 11:54 ` Radim Krčmář
2014-08-21 12:29 ` Paolo Bonzini
2014-08-21 12:42 ` Radim Krčmář
2014-08-21 13:18 ` Paolo Bonzini
2014-08-21 13:46 ` Radim Krčmář
2014-08-20 20:53 ` [PATCH v2 5/6] KVM: trace kvm_ple_window Radim Krčmář
2014-08-21 8:29 ` Paolo Bonzini
2014-08-21 11:56 ` Radim Krčmář
2014-08-21 13:22 ` Paolo Bonzini
2014-08-21 13:49 ` Radim Krčmář [this message]
2014-08-20 20:53 ` [PATCH v2 6/6] KVM: VMX: runtime knobs for dynamic PLE window Radim Krčmář
2014-08-21 6:49 ` [PATCH v2 0/6] Dynamic Pause Loop Exiting window Zhao, Hui-Zhi (Steven, HPservers-Core-OE-PSC)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140821134916.GF20453@potion.brq.redhat.com \
--to=rkrcmar@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=chegu_vinod@hp.com \
--cc=gleb@kernel.org \
--cc=hui-zhi.zhao@hp.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=raghavendra.kt@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).