From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752121AbaHUPfr (ORCPT ); Thu, 21 Aug 2014 11:35:47 -0400 Received: from mail.betterlinux.com ([199.58.199.50]:44531 "EHLO mail.betterlinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751705AbaHUPfp (ORCPT ); Thu, 21 Aug 2014 11:35:45 -0400 X-DKIM: OpenDKIM Filter v2.4.1 mail.betterlinux.com C743282206 Date: Thu, 21 Aug 2014 09:35:41 -0600 From: Andrea Righi To: Tejun Heo Cc: Li Zefan , Steven Rostedt , Ingo Molnar , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Matt Heaton Subject: Re: [PATCH] cgroup: add tracepoints to track cgroup events Message-ID: <20140821153541.GA7625@Dell> References: <1408592785-6700-1-git-send-email-andrea@betterlinux.com> <20140821141330.GA1766@mtj.dyndns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140821141330.GA1766@mtj.dyndns.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 21, 2014 at 09:13:30AM -0500, Tejun Heo wrote: > Hello, > > On Wed, Aug 20, 2014 at 09:46:25PM -0600, Andrea Righi wrote: > > This patch adds the following tracepoints: > > o trace_cgroup_create when a new cgroup is created > > o trace_cgroup_destroy when a cgroup is removed > > o trace_cgroup_task_migrate when a task/thread is moved from a cgroup to another > > > > The purpose of these tracepoints is to identify and help cgroup "managers" to > > diagnose problems and detect when they are doing an excessive amount of work. > > Using TPs for this looks like a really roundabout way of doing this > when the whole interface is based on filesystem. Extending > kernfs_notity to support directory events seems like a better way to > do this. > > Thanks. > > -- > tejun Agreed. Thanks for the suggestion, Tejun. -Andrea