Re: [PATCH] mfd: da9052-i2c: Remove duplicate test for I2C_FUNC_SMBUS_BYTE_DATA functionality

Lee Jones
2014-08-21T15:39:44Z

On Fri, 15 Aug 2014, Axel Lin wrote:

> Since commit b42261078a91 ("regmap: i2c: fallback to SMBus if the adapter
> does not support standard I2C"), regmap-i2c will check the
> I2C_FUNC_SMBUS_[BYTE|WORD]_DATA functionality based on the regmap_config
> setting if the adapter does not support standard I2C.
>
> So remove the I2C_FUNC_SMBUS_BYTE_DATA functionality check in the driver code.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/mfd/da9052-i2c.c | 7 -------
> 1 file changed, 7 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/da9052-i2c.c b/drivers/mfd/da9052-i2c.c
> index 6da8ec8..ec39287 100644
> --- a/drivers/mfd/da9052-i2c.c
> +++ b/drivers/mfd/da9052-i2c.c
> @@ -140,13 +140,6 @@ static int da9052_i2c_probe(struct i2c_client *client,
> if (!da9052)
> return -ENOMEM;
>
> - if (!i2c_check_functionality(client->adapter,
> - I2C_FUNC_SMBUS_BYTE_DATA)) {
> - dev_info(&client->dev, "Error in %s:i2c_check_functionality\n",
> - __func__);
> - return -ENODEV;
> - }
> -
> da9052->dev = &client->dev;
> da9052->chip_irq = client->irq;
> da9052->fix_io = da9052_i2c_fix;

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog