linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Luca Abeni <luca.abeni@unitn.it>
Cc: Juri Lelli <juri.lelli@arm.com>,
	peterz@infradead.org, rdunlap@infradead.org, mingo@redhat.com,
	henrik@austad.us, raistlin@linux.it, juri.lelli@gmail.com,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/4] Documentation/scheduler/sched-deadline.txt: improve and clarify AC bits
Date: Fri, 22 Aug 2014 10:31:11 +0200	[thread overview]
Message-ID: <20140822083110.GB8771@gmail.com> (raw)
In-Reply-To: <20140821164758.334a1cf7@luca-1225C>


* Luca Abeni <luca.abeni@unitn.it> wrote:

> Hi Ingo,
> 
> On Thu, 21 Aug 2014 15:38:37 +0200
> Ingo Molnar <mingo@kernel.org> wrote:
> [...]
> > > + If the total utilisation sum_i(WCET_i/P_i) (sum of the
> > > utilisations
> > > + WCET_i/P_i of all the tasks in the system - notice that when
> > > considering
> > > + multiple tasks, the parameters of the i-th one are indicated with
> > > the "_i"
> > > + suffix) is larger than M (with M equal to the number of CPUs),
> > > then the
> > > + system will surely not be able to respect all of the deadlines,
> > > and no
> > > + execution time is guaranteed for non real-time tasks, which risk
> > > to be
> > > + starved by real-time tasks.
> > 
> > The last part doesn't really parse as correct English for me - 
> > maybe also split this overly long sentence into two or three 
> > sentences, to make it easier to understand?
> Sorry about this; after re-reading the sentence, I agree it looks
> confusing. What about:

Looks good to me, with a few details:

> "
> If the total utilisation sum_i(WCET_i/P_i) is larger than M (with M
> equal to the number of CPUs), then the scheduler can not be able to
> respect all of the deadlines.

s/can not be able to respect/is unable to respect

> Note that the total utilisation is defined as the sum of the
> utilisations WCET_i/P_i of all the real-time tasks in the system (when
> considering multiple real-time tasks, the parameters of the i-th one are
> indicated with the "_i" suffix).

The parentheses are a bit confusing here - they come after a 
half finished sentence - which at the end turns out to have 
ended.

How about something like:

> Note that total utilisation is defined as the sum of the 
> utilisations WCET_i/P_i over all the real-time tasks in the 
> system. When considering multiple real-time tasks, the 
> parameters of the i-th task are indicated with the "_i" 
> suffix.

?

> Moreover, if the total utilisation is larger than M, then non real-time
> tasks risk to be starved by real-time tasks.

How about:

> Moreover, if the total utilisation is larger than M, then we 
> risk starving non- real-time tasks by real-time tasks.

?

Thanks,

	Ingo

  reply	other threads:[~2014-08-22  8:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-21  9:01 [PATCH v2 0/4] SCHED_DEADLINE documentation fixes and improvements Juri Lelli
2014-08-21  9:01 ` [PATCH v2 1/4] Documentation/scheduler/sched-deadline.txt: fix terminology and improve clarity Juri Lelli
2014-08-21  9:01 ` [PATCH v2 2/4] Documentation/scheduler/sched-deadline.txt: Rewrite section 4 intro Juri Lelli
2014-08-21 13:46   ` Ingo Molnar
2014-08-26  8:31     ` Juri Lelli
2014-08-21  9:01 ` [PATCH v2 3/4] Documentation/scheduler/sched-deadline.txt: improve and clarify AC bits Juri Lelli
2014-08-21 13:38   ` Ingo Molnar
2014-08-21 14:47     ` Luca Abeni
2014-08-22  8:31       ` Ingo Molnar [this message]
2014-08-22 20:14         ` Luca Abeni
2014-08-21  9:01 ` [PATCH v2 4/4] Documentation/scheduler/sched-deadline.txt: add tests suite appendix Juri Lelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140822083110.GB8771@gmail.com \
    --to=mingo@kernel.org \
    --cc=henrik@austad.us \
    --cc=juri.lelli@arm.com \
    --cc=juri.lelli@gmail.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca.abeni@unitn.it \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=raistlin@linux.it \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).