* [PATCH] partition-generic: Replace rcu_assign_pointer() with RCU_INIT_POINTER()
@ 2014-08-22 12:58 Andreea-Cristina Bernat
0 siblings, 0 replies; only message in thread
From: Andreea-Cristina Bernat @ 2014-08-22 12:58 UTC (permalink / raw)
To: axboe, linux-kernel; +Cc: paulmck
The uses of "rcu_assign_pointer()" are NULLing out the pointers.
According to RCU_INIT_POINTER()'s block comment:
"1. This use of RCU_INIT_POINTER() is NULLing out the pointer"
it is better to use it instead of rcu_assign_pointer() because it has a
smaller overhead.
The following Coccinelle semantic patch was used:
@@
@@
- rcu_assign_pointer
+ RCU_INIT_POINTER
(..., NULL)
Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com>
---
block/partition-generic.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/partition-generic.c b/block/partition-generic.c
index 789cdea..f1ef057 100644
--- a/block/partition-generic.c
+++ b/block/partition-generic.c
@@ -249,8 +249,8 @@ void delete_partition(struct gendisk *disk, int partno)
if (!part)
return;
- rcu_assign_pointer(ptbl->part[partno], NULL);
- rcu_assign_pointer(ptbl->last_lookup, NULL);
+ RCU_INIT_POINTER(ptbl->part[partno], NULL);
+ RCU_INIT_POINTER(ptbl->last_lookup, NULL);
kobject_put(part->holder_dir);
device_del(part_to_dev(part));
blk_free_devt(part_devt(part));
--
1.9.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2014-08-22 12:58 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-22 12:58 [PATCH] partition-generic: Replace rcu_assign_pointer() with RCU_INIT_POINTER() Andreea-Cristina Bernat
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).