Re: [PATCH 26/35] [PATCH 26/36] powerpc: Replace __get_cpu_var uses

Christoph Lameter
2014-08-18T02:45:32Z

korg tester found an issue:

From: Christoph Lameter <cl@liknux.com>
Subject: powerpc: Fix reference to opal_trace_depth.

depth is an address and not a scalar. Use & to determine the address.

Signed-off-by: Christoph Lameter <cl@linux.com>

Index: linux/arch/powerpc/platforms/powernv/opal-tracepoints.c
===================================================================
--- linux.orig/arch/powerpc/platforms/powernv/opal-tracepoints.c
+++ linux/arch/powerpc/platforms/powernv/opal-tracepoints.c
@@ -48,7 +48,7 @@ void __trace_opal_entry(unsigned long op

local_irq_save(flags);

- depth = this_cpu_ptr(opal_trace_depth);
+ depth = this_cpu_ptr(&opal_trace_depth);

if (*depth)
goto out;
@@ -69,7 +69,7 @@ void __trace_opal_exit(long opcode, unsi

local_irq_save(flags);

- depth = this_cpu_ptr(opal_trace_depth);
+ depth = this_cpu_ptr(&opal_trace_depth);

if (*depth)
goto out;