From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751758AbaHWPxr (ORCPT ); Sat, 23 Aug 2014 11:53:47 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:57164 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750809AbaHWPxq (ORCPT ); Sat, 23 Aug 2014 11:53:46 -0400 Date: Sat, 23 Aug 2014 10:53:06 -0500 From: Mark Brown To: Guenter Roeck Cc: atull@opensource.altera.com, jdelvare@suse.de, lm-sensors@lm-sensors.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, delicious.quinoa@gmail.com, dinguyen@opensource.altera.com, yvanderv@opensource.altera.com Message-ID: <20140823155306.GN24407@sirena.org.uk> References: <1408741894-24879-1-git-send-email-atull@opensource.altera.com> <1408741894-24879-3-git-send-email-atull@opensource.altera.com> <20140822214546.GD24407@sirena.org.uk> <53F8AED8.8010908@roeck-us.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="e+CieX+hyvUQgATU" Content-Disposition: inline In-Reply-To: <53F8AED8.8010908@roeck-us.net> X-Cookie: If you can read this, you're too close. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 208.59.64.2 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v2 2/2] pmbus: ltc2978: add regulator gating X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --e+CieX+hyvUQgATU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Aug 23, 2014 at 08:10:16AM -0700, Guenter Roeck wrote: > Sorry I didn't have time to review the code myself. I'll have > to check the datasheet about turning regulators on and off. > Using page 0xff for the lm2978 looks wrong, as the chip supports > up to 8 channels which should be controlled separately > (I would assume) instead of turning them all on and off in > one go. Maybe I am missing something, but my assumption would > have been to have a separate regulator for each channel, and > that each channel would have its own regulator which would be BTW I should point out that my review is just for the regulator API aspects of the change, I have no knowledge of this hardware. If what you're saying matches the hardware I'd definitely expect to see one regulator registered per physical regulator rather than a single regulator for everything on the device. --e+CieX+hyvUQgATU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJT+LjfAAoJELSic+t+oim9f5gP+wV8Oqtw7TW5LoRKUuCSpBkE 8LBhtI54Mm5nKIo9YpEggAt3xCnKO9+zy7XzMJG3JVv1KjXVwn+gEYtLSv6cZfYl HKYWM2T719KKJciBECFLzBG4t86sJMHMkSGhQ3Nx0kr2n/9Y5heIvIK9kZzqpTq1 R7wrudCaID5Vi4j88h/GjztfSbEnDRJqKEVnBvhA8hjSw/Spdz+9zBnLnIivcXLZ VQxaid0ild9t8xRoR//hkkB3beScy+6CHUlUey9UmIJbOxF5jN/ocoj5hRmU+LoH BQL0x4fHZgKb2l5dwxHLqh0WUNM4rlUj2lGc1tCY8zomOd7vr2CI2fDqtoUK20Sy VFMMUFM5HdW6E8z19I88v0bN8vHAc9t7TF22nixCkK9cTpHAYOXhR4BIXZtlS6nE eyoUYfa1vLezO40tufmJdjBbzRwcjsMeQoNZ36d9CcPtmdPkxFFtyZHsyGion2kt iqo444RmpPW/eDl8iL0EmEAta4Pv1OFh67qPLSNqpX2ICaH4YxYabVvzl2Bxxtn+ C/cZHJiQ0HdaF0kTtlbOO4/FmFnUmACftRJs49Ms5dztHEaFKf5pNFQQOayV/ehn XB24uIf9Q4h73UK2gBJLi5STIPtmD5JDxXRPt655ZqVHwe4cgK04r8td5Wl70KIl Bo0g/dDsnlQBxIkwnsb0 =d7q8 -----END PGP SIGNATURE----- --e+CieX+hyvUQgATU--