public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: "Jen-Cheng(Tommy) Huang" <tommy24@gatech.edu>
Cc: Jiri Olsa <jolsa@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [RFC 0/5] perf: Allow leader sampling on inherited events
Date: Sat, 23 Aug 2014 22:07:59 +0200	[thread overview]
Message-ID: <20140823200759.GA1972@krava.redhat.com> (raw)
In-Reply-To: <CABooUW0qEpo2YhXfxHsf48mw1acuZ63bq=Fot3kH1eHOfryU-A@mail.gmail.com>

On Sat, Aug 23, 2014 at 02:55:32PM -0400, Jen-Cheng(Tommy) Huang wrote:
> Hi Jiri,
> 
> 1. Thank you so much for providing the patch.
> I am trying to test out the patch.
> (I got the source using "git checkout -b perf
> remotes/origin/perf/core_format_group"
> after clone)
> However, the perf in your repo seems having issues with sample_read :S.
> (:S works fine with my original perf that comes with the kernel.)
> When I do
> perf record -e '{instructions,cycles}:S' /bin/ls
> 
> The following error is shown
> Error:
> The sys_perf_event_open() syscall returned with 22 (Invalid argument) for
> event (instructions).
> /bin/dmesg may provide additional information.
> No CONFIG_PERF_EVENTS=y kernel support configured?
> 
> This error does not occur without :S.
> perf record -e '{instructions,cycles}' /bin/ls
> This shows no errors.

have u boot the new kernel? there're 2 kernel patches
within the patchset

but right, the perf code should detect the kernel change
and keep old behaviour if it's not detected..

> 
> 2. Another issue I have is to show the sample value using 'perf script'.
> Currently, I am using perf report -D to show the sample read values, the
> format is not what I need. Could you give me some hints on where to modify
> to show the sample values using perf script?

there's no support in perf script to display the sample
read values.. I'll check if that could be added

thanks,
jirka

      parent reply	other threads:[~2014-08-23 20:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-22 13:05 [RFC 0/5] perf: Allow leader sampling on inherited events Jiri Olsa
2014-08-22 13:05 ` [PATCH 1/5] perf: Deny optimized switch for events read by PERF_SAMPLE_READ Jiri Olsa
2014-08-22 13:05 ` [PATCH 2/5] perf: Allow PERF_FORMAT_GROUP format on inherited events Jiri Olsa
2014-08-22 13:05 ` [PATCH 3/5] perf tools: Add support to traverse xyarrays Jiri Olsa
2014-08-22 13:05 ` [PATCH 4/5] perf tools: Add hash of periods for struct perf_sample_id Jiri Olsa
2014-08-22 13:05 ` [PATCH 5/5] perf tools: Allow PERF_FORMAT_GROUP for inherited events Jiri Olsa
2014-08-22 13:30 ` [RFC 0/5] perf: Allow leader sampling on " Jiri Olsa
     [not found]   ` <CABooUW0qEpo2YhXfxHsf48mw1acuZ63bq=Fot3kH1eHOfryU-A@mail.gmail.com>
2014-08-23 20:07     ` Jiri Olsa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140823200759.GA1972@krava.redhat.com \
    --to=jolsa@redhat.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tommy24@gatech.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox