public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Preeti U Murthy <preeti@linux.vnet.ibm.com>
Subject: Re: [GIT PULL] nohz: Fix double clock write on idle ticks
Date: Sun, 24 Aug 2014 12:07:34 +0200	[thread overview]
Message-ID: <20140824100734.GA1309@gmail.com> (raw)
In-Reply-To: <1408727373-8166-1-git-send-email-frederic@kernel.org>

* Frederic Weisbecker <fweisbec@gmail.com> wrote:

> From: Frederic Weisbecker <fweisbec@gmail.com>
> 
> Ingo,
> 
> Please pull the nohz/drop-double-write-v3 branch that can be found at:
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git
> 	nohz/drop-double-write-v3
> 
> Although the 1st patch fixes a bug, it was a longstanding issue so
> that branch doesn't need to be applied in 3.17. The next merge window
> looks better.
> 
> --
> The tick reschedules itself unconditionally. It's relevant in periodic
> mode but not in dynticks mode where it results in spurious double clock
> writes and even spurious periodic behaviour for low-res case.
> 
> This set fixes that:
> 
> * 1st patch removes low-res periodic tick rescheduling in nohz mode.
> This fixes spurious periodic behaviour.
> 
> * 2nd patch does the same for high-res mode. Here there is no such
> spurious periodic behaviour but it still spares a double clock write
> in some cases.
> ---
> 
> 
> Thanks,
> 	Frederic
> ---
> 
> Viresh Kumar (2):
>       nohz: Fix spurious periodic tick behaviour in low-res dynticks mode
>       nohz: Avoid tick's double reprogramming in highres mode
> 
> 
>  kernel/time/tick-sched.c | 8 ++++++++
>  1 file changed, 8 insertions(+)

These fixes are pretty small - any objections against putting it into
timers/urgent and including it in v3.17?

Thanks,

	Ingo

  parent reply	other threads:[~2014-08-24 10:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-22 17:09 [GIT PULL] nohz: Fix double clock write on idle ticks Frederic Weisbecker
2014-08-22 17:09 ` [PATCH 1/2] nohz: Fix spurious periodic tick behaviour in low-res dynticks mode Frederic Weisbecker
2014-08-22 17:09 ` [PATCH 2/2] nohz: Avoid tick's double reprogramming in highres mode Frederic Weisbecker
2014-08-24 10:07 ` Ingo Molnar [this message]
     [not found]   ` <CAFTL4hz8OELwXZ603UUWZQwOQE677CBeS37rB9F1OYNuM9ByOA@mail.gmail.com>
2014-08-24 14:45     ` [GIT PULL] nohz: Fix double clock write on idle ticks Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140824100734.GA1309@gmail.com \
    --to=mingo@kernel.org \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=preeti@linux.vnet.ibm.com \
    --cc=tglx@linutronix.de \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox