linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Pranith Kumar <pranith@gatech.edu>
Cc: "Amit Shah" <amit.shah@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	"Rik van Riel" <riel@redhat.com>,
	"Ingo Molnar" <mingo@kernel.org>,
	"Lai Jiangshan" <laijs@cn.fujitsu.com>,
	"Dipankar Sarma" <dipankar@in.ibm.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>,
	"Josh Triplett" <josh@joshtriplett.org>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Steven Rostedt" <rostedt@goodmis.org>,
	"David Howells" <dhowells@redhat.com>,
	"Eric Dumazet" <edumazet@google.com>,
	dvhart@linux.intel.com,
	"Frédéric Weisbecker" <fweisbec@gmail.com>,
	"Oleg Nesterov" <oleg@redhat.com>,
	"Silas Boyd-Wickizer" <sbw@mit.edu>
Subject: Re: [PATCH tip/core/rcu 1/2] rcu: Parallelize and economize NOCB kthread wakeups
Date: Sun, 24 Aug 2014 07:36:27 -0700	[thread overview]
Message-ID: <20140824143627.GL2663@linux.vnet.ibm.com> (raw)
In-Reply-To: <CAJhHMCC8C5bekoDvQs=7vcRichkmFrHK7TshuoAHFE0-7d+mtA@mail.gmail.com>

On Sat, Aug 23, 2014 at 11:39:39PM -0400, Pranith Kumar wrote:
> On Sat, Aug 23, 2014 at 11:23 PM, Paul E. McKenney
> <paulmck@linux.vnet.ibm.com> wrote:
> > On Sat, Aug 23, 2014 at 08:26:10PM -0400, Pranith Kumar wrote:
> >> On Sat, Aug 23, 2014 at 12:51 PM, Paul E. McKenney
> >> <paulmck@linux.vnet.ibm.com> wrote:
> >>
> >> > It might well!  Another possibility is that the early_initcall function
> >> > doing the synchronize_rcu() is happening before the early_initcall
> >> > creating the RCU grace-period kthreads.
> >> >
> >> > Seems like we need to close both holes.  Let's see how your patch works
> >> > for Amit, and I am testing a patch for the possible early_initcall
> >> > ordering issue.
> >>
> >> I checked the init call which is calling synchronize_rcu():
> >> subsys_initcall(pm_sysrq_init); this is being called after
> >> early_initcall.
> >>
> >> The order of initcalls is early, core, postcore, arch, subsys, fs,
> >> device, late. So I guess that is ok.
> >>
> >> I wonder why it was not showing up in 12.04. I have a dual boot. Will
> >> test it out and see if I can find something.
> >
> > Me, I am wondering about 7,000 callbacks being registered during early
> > boot time.  ;-)
> 
> This is the backtrace for most of the callbacks:

Thank you for the info!

And that explains why acpi=off helped the people running 14.04.

							Thanx, Paul

> [    4.612103] ------------[ cut here ]------------
> [    4.613340] WARNING: CPU: 0 PID: 0 at kernel/rcu/tree_plugin.h:2115
> __call_rcu_nocb_enqueue+0x58/0x283()
> [    4.615975] Modules linked in:
> [    4.616000] CPU: 0 PID: 0 Comm: swapper/0 Tainted: G        W     3.16.0+ #76
> [    4.616000] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996),
> BIOS Bochs 01/01/2011
> [    4.616000]  0000000000000000 ffffffff81803c20 ffffffff813c5213
> 0000000000000000
> [    4.616000]  ffffffff81803c58 ffffffff810388aa ffffffff8108aac8
> ffff88001f9cce40
> [    4.616000]  ffff88001f5b6c08 0000000000000000 0000000000000286
> ffffffff81803c68
> [    4.616000] Call Trace:
> [    4.616000]  [<ffffffff813c5213>] dump_stack+0x4e/0x7a
> [    4.616000]  [<ffffffff810388aa>] warn_slowpath_common+0x7f/0x98
> [    4.616000]  [<ffffffff8108aac8>] ? __call_rcu_nocb_enqueue+0x58/0x283
> [    4.616000]  [<ffffffff81038976>] warn_slowpath_null+0x1a/0x1c
> [    4.616000]  [<ffffffff8108aac8>] __call_rcu_nocb_enqueue+0x58/0x283
> [    4.616000]  [<ffffffff81129f3a>] ? unreferenced_object+0x4f/0x4f
> [    4.616000]  [<ffffffff8108d913>] __call_rcu+0xcd/0x32b
> [    4.616000]  [<ffffffff8108de66>] call_rcu+0x1b/0x1d
> [    4.616000]  [<ffffffff8112a301>] put_object+0x41/0x44
> [    4.616000]  [<ffffffff8112a70a>] delete_object_full+0x29/0x2c
> [    4.616000]  [<ffffffff813c2166>] kmemleak_free+0x25/0x43
> [    4.616000]  [<ffffffff81120cca>] slab_free_hook+0x1d/0x63
> [    4.616000]  [<ffffffff811228c6>] kmem_cache_free+0x52/0x154
> [    4.616000]  [<ffffffff8124aa01>] ? acpi_os_release_object+0xe/0x12
> [    4.616000]  [<ffffffff8124aa01>] acpi_os_release_object+0xe/0x12
> [    4.616000]  [<ffffffff8126c567>] acpi_ps_free_op+0x25/0x27
> [    4.616000]  [<ffffffff8126b81f>] acpi_ps_create_op+0x135/0x209
> [    4.616000]  [<ffffffff8126b1f2>] acpi_ps_parse_loop+0x1d3/0x575
> [    4.616000]  [<ffffffff8126bff2>] acpi_ps_parse_aml+0xa0/0x277
> [    4.616000]  [<ffffffff81267d7f>] acpi_ns_one_complete_parse+0xfc/0x11b
> [    4.616000]  [<ffffffff81267dd1>] acpi_ns_parse_table+0x33/0x38
> [    4.616000]  [<ffffffff81267755>] acpi_ns_load_table+0x4c/0x8b
> [    4.616000]  [<ffffffff81ad6797>] acpi_load_tables+0x9d/0x15d
> [    4.616000]  [<ffffffff81ad5b44>] acpi_early_init+0x73/0xfe
> [    4.616000]  [<ffffffff81aa5e8e>] start_kernel+0x3a9/0x40a
> [    4.616000]  [<ffffffff81aa5120>] ? early_idt_handlers+0x120/0x120
> [    4.616000]  [<ffffffff81aa54ba>] x86_64_start_reservations+0x2a/0x2c
> [    4.616000]  [<ffffffff81aa55f8>] x86_64_start_kernel+0x13c/0x149
> [    4.616000] ---[ end trace 8dbfee90ca96696c ]---
> 
> 
> -- 
> Pranith
> 


  reply	other threads:[~2014-08-24 14:36 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-23  7:43 [PATCH tip/core/rcu 1/2] rcu: Parallelize and economize NOCB kthread wakeups Pranith Kumar
2014-08-23 16:51 ` Paul E. McKenney
2014-08-24  0:26   ` Pranith Kumar
2014-08-24  3:23     ` Paul E. McKenney
2014-08-24  3:39       ` Pranith Kumar
2014-08-24 14:36         ` Paul E. McKenney [this message]
2014-08-27  4:43 ` Amit Shah
2014-08-27 16:21   ` Paul E. McKenney
2014-08-27 16:43     ` Pranith Kumar
2014-08-27 17:08       ` Paul E. McKenney
  -- strict thread matches above, loose matches on Subject: below --
2014-07-07 22:48 [PATCH tip/core/rcu 0/2] Callback-offloading changes for 3.17 Paul E. McKenney
2014-07-11 13:35 ` [PATCH tip/core/rcu 1/2] rcu: Parallelize and economize NOCB kthread wakeups Paul E. McKenney
2014-08-08  8:40   ` Amit Shah
2014-08-08 16:25     ` Paul E. McKenney
2014-08-08 17:37       ` Amit Shah
2014-08-08 18:18         ` Paul E. McKenney
2014-08-08 18:34           ` Amit Shah
2014-08-08 21:43             ` Paul E. McKenney
2014-08-08 21:46               ` Paul E. McKenney
2014-08-11  7:13                 ` Amit Shah
2014-08-11 16:28                   ` Paul E. McKenney
2014-08-11 19:41                     ` Amit Shah
2014-08-11 20:11                       ` Paul E. McKenney
2014-08-11 20:18                         ` Amit Shah
2014-08-11 20:34                           ` Paul E. McKenney
2014-08-12  3:45                             ` Paul E. McKenney
2014-08-12  5:33                               ` Amit Shah
2014-08-12 16:06                                 ` Paul E. McKenney
2014-08-12 21:39                                   ` Paul E. McKenney
2014-08-12 21:41                                     ` Paul E. McKenney
2014-08-12 21:44                                       ` Paul E. McKenney
2014-08-13  5:44                                       ` Amit Shah
2014-08-13 13:00                                         ` Paul E. McKenney
2014-08-13 14:18                                           ` Paul E. McKenney
2014-08-15  5:24                                           ` Amit Shah
2014-08-15 15:04                                             ` Paul E. McKenney
2014-08-18 17:53                                               ` Amit Shah
2014-08-19  4:01                                                 ` Paul E. McKenney
2014-08-22 12:24                                                   ` Amit Shah
2014-08-22 12:36                                                     ` Amit Shah
2014-08-22 12:56                                                       ` Amit Shah
2014-08-22 14:48                                                         ` Paul E. McKenney
2014-08-22 17:14                                                           ` Amit Shah
2014-08-22 17:37                                                             ` Amit Shah
2014-08-22 21:53                                                             ` Paul E. McKenney
2014-08-22 21:57                                                               ` Paul E. McKenney
2014-08-22 14:43                                                     ` Paul E. McKenney
2014-08-12  5:27                             ` Amit Shah
2014-08-12 16:08                               ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140824143627.GL2663@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=amit.shah@redhat.com \
    --cc=dhowells@redhat.com \
    --cc=dipankar@in.ibm.com \
    --cc=dvhart@linux.intel.com \
    --cc=edumazet@google.com \
    --cc=fweisbec@gmail.com \
    --cc=josh@joshtriplett.org \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mingo@kernel.org \
    --cc=oleg@redhat.com \
    --cc=peterz@infradead.org \
    --cc=pranith@gatech.edu \
    --cc=riel@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=sbw@mit.edu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).