From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932154AbaHYKRP (ORCPT ); Mon, 25 Aug 2014 06:17:15 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:20362 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753344AbaHYKRN (ORCPT ); Mon, 25 Aug 2014 06:17:13 -0400 Date: Mon, 25 Aug 2014 13:16:16 +0300 From: Dan Carpenter To: Julia Lawall Cc: Josh Triplett , Paul Mackerras , kernel-janitors@vger.kernel.org, Jean-Christophe Plagniol-Villard , Tomi Valkeinen , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 8/9] video: fbdev: aty: use c99 initializers in structures Message-ID: <20140825101616.GD5046@mwanda> References: <1408792831-25615-1-git-send-email-Julia.Lawall@lip6.fr> <1408792831-25615-9-git-send-email-Julia.Lawall@lip6.fr> <20140823152015.GB2074@thin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet21.oracle.com [141.146.126.237] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 23, 2014 at 05:32:37PM +0200, Julia Lawall wrote: > > > > The closing brace should be in column 0 of the next line. Also, the > > final field initializer should have a comma after it. (Likewise for the > > remaining changes in this file.) > > In general, I haven't changed the presence or absence of trailing commas. > Should I add them everywhere? Probably, yeah. Trailing commas are better. It's not worth resending, but the script should add them I think. regards, dan carpenter