From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934078AbaHZIXK (ORCPT ); Tue, 26 Aug 2014 04:23:10 -0400 Received: from mail-ig0-f171.google.com ([209.85.213.171]:36765 "EHLO mail-ig0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933935AbaHZIXG (ORCPT ); Tue, 26 Aug 2014 04:23:06 -0400 Date: Tue, 26 Aug 2014 09:22:58 +0100 From: Lee Jones To: Gyungoh Yoo Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, grant.likely@linaro.org, sameo@linux.intel.com, jack.yoo@skyworksinc.com, jason@lakedaemon.net, heiko.stuebner@bqreaders.com, florian.vaussard@epfl.ch, thierry.reding@gmail.com, andrew@lunn.ch, silvio.fricke@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] Adding Skyworks SKY81452 MFD driver Message-ID: <20140826082258.GC9574@lee--X1> References: <1407488899-31065-1-git-send-email-jack.yoo@skyworksinc.com> <20140821094502.GV4266@lee--X1> <20140825070608.GA6230@jack-ThinkPad-T520> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20140825070608.GA6230@jack-ThinkPad-T520> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 25 Aug 2014, Gyungoh Yoo wrote: > On Thu, Aug 21, 2014 at 10:45:02AM +0100, Lee Jones wrote: > > When you send patch-sets, you should send them connected to one > > another AKA threaded. That way, when we're reviewing we can look at > > the other patches in the set for reference. See the man page for `git > > send-email` for details. > > > > > > > > > Signed-off-by: Gyungoh Yoo > > > --- [...] > > > +static int sky81452_register_devices(struct device *dev, > > > + const struct sky81452_platform_data *pdata) > > > +{ > > > + struct mfd_cell cells[] = { > > > + { > > > + .name = "sky81452-bl", > > > + .platform_data = pdata->bl_pdata, > > > + .pdata_size = sizeof(*pdata->bl_pdata), > > > > Have you tested this with DT? > > > > You're not passing the compatible string and not using > > of_platform_populate() so I'm struggling to see how it would work > > properly. > > sky81452-bl and regulator-sky81452 is parsing the information > in regulator node of its parent node. So I thought these 2 drivers > don't need compatible attribute. That is what it didn't have > compatible string. > Is is mandatory that all drivers should have compatible attribute? How do they obtain their DT nodes? [...] > > > + return mfd_add_devices(dev, -1, cells, ARRAY_SIZE(cells), > > > + NULL, 0, NULL); > > > > This doesn't really need to be in a function of its own. Please put > > it in .probe(). Also check for the return value and present the user > > with an error message if it fails. > > I think this need to be, in case of !CONFIG_OF. > Can you please explain more in details? Then how to you obtain the shared register map you created? [...] -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog