From: Lee Jones <lee.jones@linaro.org>
To: Chris Zhong <zyw@rock-chips.com>
Cc: "Doug Anderson" <dianders@chromium.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Pawel Moll" <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Kumar Gala" <galak@codeaurora.org>,
"Samuel Ortiz" <sameo@linux.intel.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"Alessandro Zummo" <a.zummo@towertech.it>,
"Mike Turquette" <mturquette@linaro.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
rtc-linux@googlegroups.com,
"Grant Likely" <grant.likely@linaro.org>,
"Lin Huang" <hl@rock-chips.com>,
"Tao Huang" <huangtao@rock-chips.com>,
"Eddie Cai" <cf@rock-chips.com>,
zhangqing <zhangqing@rock-chips.com>, xxx <xxx@rock-chips.com>,
"Heiko Stübner" <heiko@sntech.de>,
"Olof Johansson" <olof@lixom.net>,
"Sonny Rao" <sonnyrao@chromium.org>,
"Dmitry Torokhov" <dtor@chromium.org>,
"Javier Martinez Canillas" <javier.martinez@collabora.co.uk>,
"Kever Yang" <kever.yang@rock-chips.com>
Subject: Re: [PATCH v5 2/5] MFD: RK808: Add new mfd driver for RK808
Date: Tue, 26 Aug 2014 09:36:50 +0100 [thread overview]
Message-ID: <20140826083650.GE9574@lee--X1> (raw)
In-Reply-To: <53FBF6EB.1080002@rock-chips.com>
On Tue, 26 Aug 2014, Chris Zhong wrote:
> On 08/26/2014 04:44 AM, Doug Anderson wrote:
> >On Mon, Aug 25, 2014 at 6:31 AM, Chris Zhong <zyw@rock-chips.com> wrote:
[...]
> >You need a Signed-off-by: Zhang Qing <zhangqing@rock-chips.com>
>
> Done
[...]
> >I think Lee's "Grim" comment here was that prefixing globals with "g_"
> >is not consistent with the Linux coding style. Just remove the "g_".
>
> Done
[...]
> >{ RK808_BUCK3_CONFIG_REG, BUCK_ILMIN_MASK, BUCK_ILMIN_150MA },
> >
> >instead of:
> >
> >{RK808_BUCK3_CONFIG_REG, BUCK_ILMIN_MASK, BUCK_ILMIN_150MA},
>
> Done
[...]
> >nit: add spacing so that VB_LO_SEL_3500MV lines up under VB_LO_ACT
>
> Done
[...]
> >I think Lee wanted the above to be:
> >
> > { "rk808", },
>
> Done
[...]
> >I think Lee wanted you to remove ".owner = THIS_MODULE"
>
> Done
[...]
You've just spammed 10(00)'s of people with an email that contains
zero useful content.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-08-26 8:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-25 13:31 [PATCH v5 2/5] MFD: RK808: Add new mfd driver for RK808 Chris Zhong
2014-08-25 20:44 ` Doug Anderson
2014-08-26 2:54 ` Chris Zhong
2014-08-26 8:36 ` Lee Jones [this message]
2014-08-26 8:32 ` Lee Jones
2014-08-26 16:57 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140826083650.GE9574@lee--X1 \
--to=lee.jones@linaro.org \
--cc=a.zummo@towertech.it \
--cc=broonie@kernel.org \
--cc=cf@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dtor@chromium.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=heiko@sntech.de \
--cc=hl@rock-chips.com \
--cc=huangtao@rock-chips.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=javier.martinez@collabora.co.uk \
--cc=kever.yang@rock-chips.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@linaro.org \
--cc=olof@lixom.net \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=sameo@linux.intel.com \
--cc=sonnyrao@chromium.org \
--cc=xxx@rock-chips.com \
--cc=zhangqing@rock-chips.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox