Re: [PATCH 09/18] backlight: lm3639: remove unnecessary return statements

Lee Jones
2014-08-26T16:34:15Z

On Tue, 26 Aug 2014, Jingoo Han wrote:

> Fixed the following checkpatch warning.
>
> WARNING: void function return statements are not generally useful
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/video/backlight/lm3639_bl.c | 2 --
> 1 file changed, 2 deletions(-)

Acked-by: Lee Jones <lee.jones@linaro.org>

> diff --git a/drivers/video/backlight/lm3639_bl.c b/drivers/video/backlight/lm3639_bl.c
> index 5f36808d214f..cd50df5807ea 100644
> --- a/drivers/video/backlight/lm3639_bl.c
> +++ b/drivers/video/backlight/lm3639_bl.c
> @@ -254,7 +254,6 @@ static void lm3639_torch_brightness_set(struct led_classdev *cdev,
> return;
> out:
> dev_err(pchip->dev, "i2c failed to access register\n");
> - return;
> }
>
> /* flash */
> @@ -293,7 +292,6 @@ static void lm3639_flash_brightness_set(struct led_classdev *cdev,
> return;
> out:
> dev_err(pchip->dev, "i2c failed to access register\n");
> - return;
> }
>
> static const struct regmap_config lm3639_regmap = {