Re: [PATCH 07/18] backlight: ili922x: remove 'else' after a return

Lee Jones
2014-08-26T16:35:22Z

On Tue, 26 Aug 2014, Jingoo Han wrote:

> Fixed the following checkpatch warning.
>
> WARNING: else is not generally useful after a break or return
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/video/backlight/ili922x.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)

Acked-by: Lee Jones <lee.jones@linaro.org>

> diff --git a/drivers/video/backlight/ili922x.c b/drivers/video/backlight/ili922x.c
> index ea67fe199e34..e7f0890cc211 100644
> --- a/drivers/video/backlight/ili922x.c
> +++ b/drivers/video/backlight/ili922x.c
> @@ -495,17 +495,18 @@ static int ili922x_probe(struct spi_device *spi)
> "no LCD found: Chip ID 0x%x, ret %d\n",
> reg, ret);
> return -ENODEV;
> - } else {
> - dev_info(&spi->dev, "ILI%x found, SPI freq %d, mode %d\n",
> - reg, spi->max_speed_hz, spi->mode);
> }
>
> + dev_info(&spi->dev, "ILI%x found, SPI freq %d, mode %d\n",
> + reg, spi->max_speed_hz, spi->mode);
> +
> ret = ili922x_read_status(spi, &reg);
> if (ret) {
> dev_err(&spi->dev, "reading RS failed...\n");
> return ret;
> - } else
> - dev_dbg(&spi->dev, "status: 0x%x\n", reg);
> + }
> +
> + dev_dbg(&spi->dev, "status: 0x%x\n", reg);
>
> ili922x_display_init(spi);