Re: [PATCH 08/18] backlight: ld9040: remove 'else' after a return

Lee Jones
2014-08-26T16:34:39Z

On Tue, 26 Aug 2014, Jingoo Han wrote:

> Fixed the following checkpatch warning.
>
> WARNING: else is not generally useful after a break or return
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/video/backlight/ld9040.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)

Acked-by: Lee Jones <lee.jones@linaro.org>

> diff --git a/drivers/video/backlight/ld9040.c b/drivers/video/backlight/ld9040.c
> index ccb44e8e4927..f71eaf10c4eb 100644
> --- a/drivers/video/backlight/ld9040.c
> +++ b/drivers/video/backlight/ld9040.c
> @@ -566,11 +566,11 @@ static int ld9040_power_on(struct ld9040 *lcd)
> if (!pd->reset) {
> dev_err(lcd->dev, "reset is NULL.\n");
> return -EINVAL;
> - } else {
> - pd->reset(lcd->ld);
> - msleep(pd->reset_delay);
> }
>
> + pd->reset(lcd->ld);
> + msleep(pd->reset_delay);
> +
> ret = ld9040_ldi_init(lcd);
> if (ret) {
> dev_err(lcd->dev, "failed to initialize ldi.\n");