Re: [PATCH 10/18] backlight: lms501kf03: remove 'else' after a return

Lee Jones
2014-08-26T16:33:47Z

On Tue, 26 Aug 2014, Jingoo Han wrote:

> Fixed the following checkpatch warning.
>
> WARNING: else is not generally useful after a break or return
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/video/backlight/lms501kf03.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)

Acked-by: Lee Jones <lee.jones@linaro.org>

> diff --git a/drivers/video/backlight/lms501kf03.c b/drivers/video/backlight/lms501kf03.c
> index 77258b7b04be..7e3810308c3e 100644
> --- a/drivers/video/backlight/lms501kf03.c
> +++ b/drivers/video/backlight/lms501kf03.c
> @@ -232,19 +232,19 @@ static int lms501kf03_power_on(struct lms501kf03 *lcd)
> if (!pd->power_on) {
> dev_err(lcd->dev, "power_on is NULL.\n");
> return -EINVAL;
> - } else {
> - pd->power_on(lcd->ld, 1);
> - msleep(pd->power_on_delay);
> }
>
> + pd->power_on(lcd->ld, 1);
> + msleep(pd->power_on_delay);
> +
> if (!pd->reset) {
> dev_err(lcd->dev, "reset is NULL.\n");
> return -EINVAL;
> - } else {
> - pd->reset(lcd->ld);
> - msleep(pd->reset_delay);
> }
>
> + pd->reset(lcd->ld);
> + msleep(pd->reset_delay);
> +
> ret = lms501kf03_ldi_init(lcd);
> if (ret) {
> dev_err(lcd->dev, "failed to initialize ldi.\n");