From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752272AbaHZQwP (ORCPT ); Tue, 26 Aug 2014 12:52:15 -0400 Received: from fw-tnat.austin.arm.com ([217.140.110.23]:36232 "EHLO collaborate-mta1.arm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750823AbaHZQwO (ORCPT ); Tue, 26 Aug 2014 12:52:14 -0400 Date: Tue, 26 Aug 2014 17:51:38 +0100 From: Catalin Marinas To: Marc Zyngier Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-omap@vger.kernel.org" , "linux@openrisc.net" , "linux@arm.linux.org.uk" , "shawn.guo@freescale.com" , "kernel@pengutronix.de" , "tony@atomide.com" , Will Deacon , "jonas@southpole.se" , "tglx@linutronix.de" , "jason@lakedaemon.net" , "shc_work@mail.ru" , "baohua@kernel.org" , "maxime.ripard@free-electrons.com" , "khilman@linaro.org" , "sboyd@codeaurora.org" , Lorenzo Pieralisi , "larry.bassel@linaro.org" , Mark Rutland , Sudeep Holla , "stefan.kristiansson@saunalahti.fi" , "vkale@apm.com" , "schwidefsky@de.ibm.com" Subject: Re: [PATCH v2 02/26] arm64: convert handle_IRQ to use __handle_domain_irq Message-ID: <20140826165138.GM16482@arm.com> References: <1409047421-27649-1-git-send-email-marc.zyngier@arm.com> <1409047421-27649-3-git-send-email-marc.zyngier@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1409047421-27649-3-git-send-email-marc.zyngier@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 26, 2014 at 11:03:17AM +0100, Marc Zyngier wrote: > In order to limit code duplication, convert the architecture specific > handle_IRQ to use the generic __handle_domain_irq function. > > Signed-off-by: Marc Zyngier > --- > arch/arm64/Kconfig | 1 + > arch/arm64/kernel/irq.c | 18 +----------------- > 2 files changed, 2 insertions(+), 17 deletions(-) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index fd4e81a..1f16ed9 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -30,6 +30,7 @@ config ARM64 > select GENERIC_STRNCPY_FROM_USER > select GENERIC_STRNLEN_USER > select GENERIC_TIME_VSYSCALL > + select HANDLE_DOMAIN_IRQ > select HARDIRQS_SW_RESEND > select HAVE_ARCH_AUDITSYSCALL > select HAVE_ARCH_JUMP_LABEL > diff --git a/arch/arm64/kernel/irq.c b/arch/arm64/kernel/irq.c > index 0f08dfd..2c0e2a7 100644 > --- a/arch/arm64/kernel/irq.c > +++ b/arch/arm64/kernel/irq.c > @@ -48,23 +48,7 @@ int arch_show_interrupts(struct seq_file *p, int prec) > */ > void handle_IRQ(unsigned int irq, struct pt_regs *regs) > { > - struct pt_regs *old_regs = set_irq_regs(regs); > - > - irq_enter(); > - > - /* > - * Some hardware gives randomly wrong interrupts. Rather > - * than crashing, do something sensible. > - */ > - if (unlikely(irq >= nr_irqs)) { > - pr_warn_ratelimited("Bad IRQ%u\n", irq); > - ack_bad_irq(irq); > - } else { > - generic_handle_irq(irq); > - } > - > - irq_exit(); > - set_irq_regs(old_regs); > + __handle_domain_irq(NULL, irq, false, regs); > } The only thing that's missing is a pr_warn_ratelimited(). Do we still need it? We could add it to ack_bad_irq() though. Either way: Acked-by: Catalin Marinas