Re: [RESUBMIT PATCH v6 7/8] regulator: sky81452: Add compatible string for device binding

Mark Brown
2014-11-04T00:55:12Z

[-- Attachment #1: Type: text/plain, Size: 892 bytes --]

On Tue, Nov 04, 2014 at 09:43:34AM +0900, Gyungoh Yoo wrote:
> On Fri, Oct 31, 2014 at 04:44:18PM +0000, Mark Brown wrote:

> > This doesn't apply against current code and depends on the MFD symbol
> > rename - can you please check what's going on here?

> Are you talking about 'sky81452-regulator'?
> I am sorry I don't understand. Can you explain in more detail?

No, I mean the Kconfig change.

> > It would make sense to split the Kconfig symbol rename into a separate
> > patch to ease merging, it doesn't seem obviously related to the driver
> > change and should probably be in the same patch as the MFD symbol rename
> > for bisetion.

> becuase the symbol in the modfied MFD does not match with the
> merged regulator driver, it was hard to split the patch.

I'm having a hard time understanding why it is difficult to split the
two changes - they are in completely separate files.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]