Re: [RESUBMIT PATCH v4 7/8] regulator: sky81452: Add compatible string for device binding

Mark Brown
2014-10-13T10:35:57Z

[-- Attachment #1: Type: text/plain, Size: 470 bytes --]

On Mon, Oct 13, 2014 at 02:47:41PM +0900, Gyungoh Yoo wrote:

> - np = of_get_child_by_name(dev->parent->of_node, "regulator");
> - if (unlikely(!np)) {
> + if (!np) {
> dev_err(dev, "regulator node not found");
> - return NULL;
> + return ERR_PTR(-ENODATA);
> }

If you're doing anything here you should convert the code to use the
simplified interface for parsing regulator data based on putting the
subnode name and regualtor name in the regulator descriptor.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]