Re: [RESUBMIT PATCH v4 7/8] regulator: sky81452: Add compatible string for device binding

Mark Brown
2014-10-17T10:18:26Z

[-- Attachment #1: Type: text/plain, Size: 571 bytes --]

On Fri, Oct 17, 2014 at 06:19:50PM +0900, Gyungoh Yoo wrote:

> Wow. I understand.
> I missed .supply_name. I think I need something like
> below, before devm_regulator_register().

> config->supply_name = init_data->constraints.name;

> I will resubmit it.

No, not supply_name (though you really should be initializing that
anyway) and you definitely don't want to set supply_name to something
from constraints. The supply_name should be the name of the input pin
that supplies power to the regulator. I was referring to of_match and
regulators_node.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]